Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-476: refactor last tests #1145

Closed
wants to merge 1 commit into from
Closed

PAINTROID-476: refactor last tests #1145

wants to merge 1 commit into from

Conversation

akebu6
Copy link
Contributor

@akebu6 akebu6 commented Aug 9, 2022 •
edited
Loading

Jira Ticket: https://jira.catrob.at/browse/PAINTROID-476
Refactor the remaining test cases from Java to Kotlin:

  • TextToolIntegrationTest
  • LineToolIntegrationTest
  • PipetteToolIntegrationTest
  • TextToolFontListTest
  • TextToolFontListArabic

All tests pass locally and on Jerkins

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@akebu6 akebu6 marked this pull request as draft August 9, 2022 09:18
@akebu6 akebu6 marked this pull request as ready for review August 27, 2022 16:02
@akebu6 akebu6 force-pushed the PAINTROID-476 branch 2 times, most recently from 67d2343 to 92a551c Compare September 10, 2022 23:13
@akebu6
PAINTROID-476: refactored tests to Kotlin
c553036 
PAINTROID-476: refactored tests to Kotlin

PAINTROID-476: refactored tests to Kotlin

Refactored and fixed files

[code]: refactor tests to kotlin

[chore]: modified file

chore: modified file
@ThorstenBandel
Copy link
Contributor

There is a conflict and 2 tests are newly failing
https://jenkins.catrob.at/job/Paintroid/job/PR-1145/12/testReport/junit/org.catrobat.paintroid.test.espresso/ToolOnBackPressedIntegrationTest/Tests___Device_Tests___testBrushToolBackPressedFromCatroidAndUsePicture/
https://jenkins.catrob.at/job/Paintroid/job/PR-1145/12/testReport/junit/org.catrobat.paintroid.test.espresso/ToolOnBackPressedIntegrationTest/Tests___Device_Tests___testBrushToolBackPressedWithSaveAndOverride/
Please fix those problems, thanks :D

@ThorstenBandel
Copy link
Contributor

Finished by #1202
Your code was used in the PR Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akebu6 @ThorstenBandel