Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID 476 - Refactor test cases from Java to Kotlin #1202

Merged
merged 2 commits into from
Feb 16, 2023
Merged

PAINTROID 476 - Refactor test cases from Java to Kotlin #1202

merged 2 commits into from
Feb 16, 2023

Conversation

bakicelebi
Copy link
Contributor

@bakicelebi bakicelebi commented Feb 2, 2023 •
edited by Lenkomotive
Loading

PAINTROID-476

Fixed LineToolIntegrationTest and PipetteToolIntegrationTest. TextToolFontListTest, TextToolIntegrationTest and TextToolFontListArabic were already functioning. Testing with swipe gesture was not working. Switched to touchAt

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

akebu6 and others added 2 commits February 2, 2023 21:55
@akebu6 @bakicelebi
PAINTROID-476: refactored tests to Kotlin
eb35004 
PAINTROID-476: refactored tests to Kotlin

PAINTROID-476: refactored tests to Kotlin

Refactored and fixed files

[code]: refactor tests to kotlin

[chore]: modified file

chore: modified file
@bakicelebi
PAINTROID-476 Refactor test cases from Java to Kotlin
0e5e88e
@bakicelebi bakicelebi changed the title Paintroid 476 Paintroid 476 - Refactor test cases from Java to Kotlin Feb 2, 2023
@bakicelebi bakicelebi changed the title Paintroid 476 - Refactor test cases from Java to Kotlin PAINTROID 476 - Refactor test cases from Java to Kotlin Feb 3, 2023
@ThorstenBandel
Copy link
Contributor

There are 71 Tests failing, please take a look at them (if it is fixed by another PR please mention this instead)

@bakicelebi
Copy link
Contributor Author

bakicelebi commented Feb 11, 2023 •
edited
Loading

There are 71 Tests failing, please take a look at them (if it is fixed by another PR please mention this instead)

Jenkins might have had issues with build #6 since it took 1h6min (all other previous builds took less than 30min). I rebuilt/retested and it seems to be working again.

ThorstenBandel
ThorstenBandel approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ThorstenBandel ThorstenBandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThorstenBandel ThorstenBandel merged commit 06af955 into Catrobat:develop Feb 16, 2023
@ThorstenBandel ThorstenBandel mentioned this pull request Feb 16, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lenkomotive Lenkomotive Lenkomotive approved these changes

@exland exland exland approved these changes

@ThorstenBandel ThorstenBandel ThorstenBandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bakicelebi @ThorstenBandel @exland @Lenkomotive @akebu6