Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing 'refine' in root #303

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Feb 22, 2024

(Builds upon #302 , to be merged first)

Fixes #301

A missing 'refine' in a root tile was not detected by the validator until now. With this PR, it causes an TILE_REFINE_MISSING_IN_ROOT error to be issued.

NOTE: The actual fix was pretty simple, and only consists of the small code block at a76420a#diff-16f3605f538db4f2045f8481ccc3ed655a2c44eb2c4d066f19e102065719eaacR186

The large number of changed files here stems from the fact that all the /spec tileset JSON files did generally not define the refine property in the root. So they have been updated to include it as necessary.

@lilleyse lilleyse merged commit 82aa2cc into main Feb 22, 2024
2 checks passed
@lilleyse lilleyse deleted the handle-missing-refine-in-root branch February 22, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 'refine' in root tile is not detected
2 participants