CesiumGS · lilleyse · Feb 22, 2024 · Feb 22, 2024 · Feb 22, 2024 · Feb 22, 2024
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
     "@gltf-transform/core": "^3.2.1",
     "@gltf-transform/extensions": "^3.2.1",
     "@gltf-transform/functions": "^3.2.1",
-    "3d-tiles-tools": "0.3.1",
+    "3d-tiles-tools": "0.4.1",
     "cesium": "^1.97.0",
     "gltf-validator": "^2.0.0-dev.3.9",
     "minimatch": "^5.1.0",

diff --git a/specs/TilesetValidationSpec.ts b/specs/TilesetValidationSpec.ts
@@ -580,6 +580,22 @@ describe("Tileset validation", function () {
     expect(result.get(0).type).toEqual("VALUE_NOT_IN_LIST");
   });
 
+  it("detects issues in tileRefineMissingInRoot", async function () {
+    const result = await Validators.validateTilesetFile(
+      "specs/data/tilesets/tileRefineMissingInRoot.json"
+    );
+    expect(result.length).toEqual(1);
+    expect(result.get(0).type).toEqual("TILE_REFINE_MISSING_IN_ROOT");
+  });
+
+  it("detects issues in tileRefineMissingInRootOfExternal", async function () {
+    const result = await Validators.validateTilesetFile(
+      "specs/data/tilesets/tileRefineMissingInRootOfExternal.json"
+    );
+    expect(result.length).toEqual(1);
+    expect(result.get(0).type).toEqual("EXTERNAL_TILESET_VALIDATION_ERROR");
+  });
+
   it("detects issues in tileRefineWrongCase", async function () {
     const result = await Validators.validateTilesetFile(
       "specs/data/tilesets/tileRefineWrongCase.json"

diff --git a/specs/data/tilesets/assetTilesetVersionInvalidType.json b/specs/data/tilesets/assetTilesetVersionInvalidType.json
@@ -5,6 +5,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/assetVersionInvalidType.json b/specs/data/tilesets/assetVersionInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/assetVersionMissing.json b/specs/data/tilesets/assetVersionMissing.json
@@ -3,6 +3,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/assetVersionUnknown.json b/specs/data/tilesets/assetVersionUnknown.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionFoundButNotUsed.json b/specs/data/tilesets/extensionFoundButNotUsed.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ],
       "extensions": {

diff --git a/specs/data/tilesets/extensionNotDeclared_1_0_glTF.json b/specs/data/tilesets/extensionNotDeclared_1_0_glTF.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionNotNecessary_1_1_glTF.json b/specs/data/tilesets/extensionNotNecessary_1_1_glTF.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionRequiredButNotUsed.json b/specs/data/tilesets/extensionRequiredButNotUsed.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionUsedButNotFound.json b/specs/data/tilesets/extensionUsedButNotFound.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ],
       "extensions": {

diff --git a/specs/data/tilesets/extensionsInvalidType.json b/specs/data/tilesets/extensionsInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsRequiredDuplicateElement.json b/specs/data/tilesets/extensionsRequiredDuplicateElement.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsRequiredInvalidArrayLength.json b/specs/data/tilesets/extensionsRequiredInvalidArrayLength.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsRequiredInvalidType.json b/specs/data/tilesets/extensionsRequiredInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsUsedDuplicateElement.json b/specs/data/tilesets/extensionsUsedDuplicateElement.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsUsedInvalidArrayLength.json b/specs/data/tilesets/extensionsUsedInvalidArrayLength.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsUsedInvalidType.json b/specs/data/tilesets/extensionsUsedInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extensionsValueInvalidType.json b/specs/data/tilesets/extensionsValueInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/extrasUnexpectedType.json b/specs/data/tilesets/extrasUnexpectedType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/groupClassIdInvalid.json b/specs/data/tilesets/groupClassIdInvalid.json
@@ -16,6 +16,7 @@
   ],
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/groupClassIdInvalidType.json b/specs/data/tilesets/groupClassIdInvalidType.json
@@ -16,6 +16,7 @@
   ],
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/groupWithoutSchema.json b/specs/data/tilesets/groupWithoutSchema.json
@@ -9,6 +9,7 @@
   ],
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/packages/tilesetPackageWithWarnings.3dtiles b/specs/data/tilesets/packages/tilesetPackageWithWarnings.3dtiles
diff --git a/specs/data/tilesets/packages/tilesetPackageWithWarnings.3tz b/specs/data/tilesets/packages/tilesetPackageWithWarnings.3tz
diff --git a/specs/data/tilesets/packages/tilesetPackageWithWarnings/tileset.json b/specs/data/tilesets/packages/tilesetPackageWithWarnings/tileset.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/packages/validTilesetPackage.3dtiles b/specs/data/tilesets/packages/validTilesetPackage.3dtiles
diff --git a/specs/data/tilesets/packages/validTilesetPackage.3tz b/specs/data/tilesets/packages/validTilesetPackage.3tz
diff --git a/specs/data/tilesets/packages/validTilesetPackage/tileset.json b/specs/data/tilesets/packages/validTilesetPackage/tileset.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/packages/validTilesetPackageZipped.3dtiles b/specs/data/tilesets/packages/validTilesetPackageZipped.3dtiles
diff --git a/specs/data/tilesets/packages/validTilesetPackageZipped.3tz b/specs/data/tilesets/packages/validTilesetPackageZipped.3tz
diff --git a/specs/data/tilesets/propertiesInvalidType.json b/specs/data/tilesets/propertiesInvalidType.json
@@ -7,6 +7,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/propertiesMaximumInvalidType.json b/specs/data/tilesets/propertiesMaximumInvalidType.json
@@ -10,6 +10,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/propertiesMaximumMissing.json b/specs/data/tilesets/propertiesMaximumMissing.json
@@ -9,6 +9,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/propertiesMinimumInvalidType.json b/specs/data/tilesets/propertiesMinimumInvalidType.json
@@ -10,6 +10,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/propertiesMinimumLargerThanMaximum.json b/specs/data/tilesets/propertiesMinimumLargerThanMaximum.json
@@ -10,6 +10,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/propertiesMinimumMissing.json b/specs/data/tilesets/propertiesMinimumMissing.json
@@ -9,6 +9,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/statisticsClassesIdInvalid.json b/specs/data/tilesets/statisticsClassesIdInvalid.json
@@ -17,6 +17,7 @@
   },
   "geometricError": 2.0,
   "root": {
+    "refine": "REPLACE",
     "boundingVolume": {
       "box": [0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5]
     },

diff --git a/specs/data/tilesets/statisticsClassesInvalidType.json b/specs/data/tilesets/statisticsClassesInvalidType.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/statisticsClassesMinPropertiesMismatch.json b/specs/data/tilesets/statisticsClassesMinPropertiesMismatch.json
@@ -17,6 +17,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/statisticsClassesPropertiesMinPropertiesMismatch.json b/specs/data/tilesets/statisticsClassesPropertiesMinPropertiesMismatch.json
@@ -17,6 +17,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/statisticsClassesPropertiesPropertyNameInvalid.json b/specs/data/tilesets/statisticsClassesPropertiesPropertyNameInvalid.json
@@ -17,6 +17,7 @@
   },
   "geometricError": 2.0,
   "root": {
+    "refine": "REPLACE",
     "boundingVolume": {
       "box": [0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5]
     },

diff --git a/specs/data/tilesets/statisticsClassesValueInvalidType.json b/specs/data/tilesets/statisticsClassesValueInvalidType.json
@@ -7,6 +7,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/statisticsClassesWithoutSchema.json b/specs/data/tilesets/statisticsClassesWithoutSchema.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/tileChildrenEmptyArray.json b/specs/data/tilesets/tileChildrenEmptyArray.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/tileContentBoundingVolumeNotInTileBoundingVolume.json b/specs/data/tilesets/tileContentBoundingVolumeNotInTileBoundingVolume.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/tileGeometricErrorMissing.json b/specs/data/tilesets/tileGeometricErrorMissing.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     }

diff --git a/specs/data/tilesets/tileGeometricErrorNegative.json b/specs/data/tilesets/tileGeometricErrorNegative.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 2.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/tileGeometricErrorNotSmallerThanParentGeometricError.json b/specs/data/tilesets/tileGeometricErrorNotSmallerThanParentGeometricError.json
@@ -4,6 +4,7 @@
   },
   "geometricError" : 8.0,
   "root" : {
+    "refine": "REPLACE",
     "boundingVolume" : {
       "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
     },

diff --git a/specs/data/tilesets/tileRefineMissingInRoot.json b/specs/data/tilesets/tileRefineMissingInRoot.json
@@ -0,0 +1,21 @@
+{
+  "asset" : {
+    "version" : "1.1"
+  },
+  "geometricError" : 2.0,
+  "root" : {
+    "boundingVolume" : {
+      "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
+    },
+    "geometricError" : 1.0,
+    "children": [
+      {
+        "boundingVolume" : {
+          "box" : [ 0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5 ]
+        },
+        "geometricError" : 0.0,
+        "refine": "ADD"
+      }
+    ]
+  }
+}