Material and imagery refactor for Kit 105 #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
This PR removes a bunch of workarounds that we had in place for Kit 104.2 since it didn't support dynamic material values.
baseColorFactor
,emissiveFactor
, etc in the material definition.Only one imagery layer is supported per tileset still. Multiple raster overlays is a bigger lift since it means parsing multiple texcoord sets from the glTF (e.g. geographic vs. web mercator texcoords), storing multiple textures in
FabricMaterial
(possibly requiring a texture pool), and forking gltf/pbr.mdl to read from additional textures.