Don't call initializeFrame when the canvas size is 0 #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the default render loop call `scene.initializeFrame` when the canvas height or width is 0 causes issues in camera code which expects these values to be non-zero. As far as I can tell, similar to `render`, there's no reason we should be calling `initializeFrame` in this case anyway. Fixes #2662 (some additional discussion there as well)
|
Problem fixed, tests pass. |
emackey
added a commit
that referenced
this pull request
Apr 28, 2015
Don't call initializeFrame when the canvas size is 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the default render loop call
scene.initializeFramewhen the canvas height or width is 0 causes issues in camera code which expects these values to be non-zero. As far as I can tell, similar torender, there's no reason we should be callinginitializeFramein this case anyway.Fixes #2662 (some additional discussion there as well)