Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call initializeFrame when the canvas size is 0 #2668

Merged
merged 2 commits into from
Apr 28, 2015
Merged

Don't call initializeFrame when the canvas size is 0 #2668

merged 2 commits into from
Apr 28, 2015

Commits on Apr 28, 2015

  1. Don't call initializeFrame when the canvas size is 0 

    Having the default render loop call `scene.initializeFrame` when the canvas
height or width is 0 causes issues in camera code which expects these
values to be non-zero.  As far as I can tell, similar to `render`, there's
no reason we should be calling `initializeFrame` in this case anyway.

Fixes #2662 (some additional discussion there as well)
    @mramato
    mramato committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    b8dcb0d View commit details
    Browse the repository at this point in the history

  2. Update CHANGES

    @mramato
    mramato committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    af469fa View commit details
    Browse the repository at this point in the history