Fix Issue 884 #889
Merged
Fix Issue 884 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,7 +295,6 @@ define([ | |||
| return; | |||
| } | |||
| this.onTransitionStart.raiseEvent(this, this._previousMode, SceneMode.SCENE3D, true); | |||
| this._previousMode = SceneMode.MORPHING; | |||
There was a problem hiding this comment.
Lines 242 and 269 have the same code. Does it have to be removed there as well? I also need to make sure that this doesn't break anything else (SceneModePicker for instances).
There was a problem hiding this comment.
Yes, I removed them. I don't think the map jumps to being partly off screen anymore (#513). Could you test that too?
There was a problem hiding this comment.
#513 still happens for me, even with these changes.
|
@emackey I think this is fixed, can you try to reproduce it to make sure; since you are the one that originally found it. |
|
Tests pass, merge when happy. |
|
Looks good, thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when morphing from 2D to 3D. #884.