fix(dot/network): Implement time based handle transaction #1942

arijitAD · 2021-10-29T15:26:44Z

Changes

Implement time based handle transaction

Tests

TestCreateNotificationsMessageHandler_HandleTransaction

Issues

closes Implement time based batch processing of transcation message. #1788

Primary Reviewer

@EclesioMeloJunior

noot · 2021-11-03T21:12:59Z

dot/network/transaction.go

+			case <-s.ctx.Done():
+				return
+			case <-ticker.C:
+				innerTicker := time.NewTicker(300 * time.Millisecond)


where did this time come from? and what's the purpose of it exactly?

The external tick triggers at a regular interval of slotDuration. The inner tick was to trigger timeout, so that it doesn't take the entire slotDuration. I have updated the code to use a timer.

noot · 2021-11-03T21:14:05Z

dot/network/transaction.go

+func (s *Service) createBatchMessageHandler(txnBatchCh chan *BatchMessage) NotificationsMessageBatchHandler {
+	go func() {
+		protocolID := s.host.protocolID + transactionsID
+		ticker := time.NewTicker(1 * time.Second)


it would be nice to configure this using slot duration, i think 1/3 a slot duration is reasonable, that way the node has 1/3 a slot to process the transaction messages and put them in the pool if they want. what do you think?

dot/network/transaction.go

codecov · 2021-11-08T07:52:44Z

Codecov Report

Merging #1942 (a5dcfde) into development (844802a) will decrease coverage by 0.05%.
The diff coverage is 61.42%.

❗ Current head a5dcfde differs from pull request most recent head a297154. Consider uploading reports for the commit a297154 to get more accurate results

@@               Coverage Diff               @@
##           development    #1942      +/-   ##
===============================================
- Coverage        60.70%   60.64%   -0.06%     
===============================================
  Files              202      202              
  Lines            27246    27268      +22     
===============================================
- Hits             16540    16537       -3     
- Misses            8810     8832      +22     
- Partials          1896     1899       +3

Flag	Coverage Δ
unit-tests	`60.64% <61.42%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/network/config.go	`64.47% <ø> (ø)`
dot/network/host.go	`61.47% <0.00%> (-2.49%)`	⬇️
dot/network/test_helpers.go	`82.51% <0.00%> (ø)`
dot/services.go	`68.15% <40.00%> (-0.56%)`	⬇️
dot/network/notifications.go	`65.85% <53.84%> (-3.15%)`	⬇️
dot/network/transaction.go	`63.33% <81.08%> (+1.36%)`	⬆️
dot/network/service.go	`57.96% <100.00%> (+0.18%)`	⬆️
dot/network/connmgr.go	`74.73% <0.00%> (-1.06%)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844802a...a297154. Read the comment docs.

jimjbrettj · 2021-11-08T17:27:51Z

dot/network/notifications.go

@@ -58,7 +58,7 @@ type (
 	NotificationsMessageHandler = func(peer peer.ID, msg NotificationsMessage) (propagate bool, err error)

 	// NotificationsMessageBatchHandler is called when a (non-handshake) message is received over a notifications stream in batch processing mode.


This is just for me to gain understanding, but what is the distinction here between a handshake and a non-handshake message when in batch processing mode, and why do they have to be handled differently?

when a notifications stream is opened (see docs on the different stream types here https://docs.rs/sc-network/0.9.0/sc_network/) the first message each side sends to each other over it is a "handshake" message, which each side validates and if they don't like it they close the stream, otherwise it stays open and the rest of the messages that are sent over the stream (by the opening side only) are the normal messages for that stream protocol, so in this case TransactionMessages

Ah okay that makes sense. I wasn't sure if handshake meant something different in this context, but this sounds like what I would think of as a typical handshake for establishing connection between peers (correct me if I'm misunderstanding though). And to clarify, the streams are one sided in this case?

Yes, After handshake the steam is unidirectional.

yeah, it's not exactly the same as a handshake for estabilishing connection/public keys, but it's a more high-level stream level handshake

noot

great work :D

dot/network/transaction.go

EclesioMeloJunior · 2021-11-11T12:47:37Z

dot/network/transaction.go

+					select {
+					case <-timeOut.C:
+						break out
+					case txnMsg := <-txnBatchCh:


is a problem in this case condition blocks the thread for more than the ticker duration? if yes, we might need to call a goroutine every tick to avoid this blocking

We are processing as many txns as possible within timeOut . If there is no data in channel then timeOut will be triggered.

But I'm asking if the process of a txnMsg takes for more than a ticker duration, for example lets say handleTransactionMessage blocks

Then we don't process it. We process it in the next block.

dot/network/transaction.go

…dle-transaction

dot/network/config.go

dot/network/host.go

dot/network/notifications.go

dot/network/service_test.go

dot/network/transaction.go

…dle-transaction

dot/network/config.go

dot/network/host.go

dot/network/transaction.go

qdm12 · 2021-11-23T11:00:18Z

dot/network/transaction.go

-		if len(txnBatch) < s.batchSize {
-			return nil, nil
-		}
+		timeOut := time.NewTimer(time.Millisecond * 200)


What's the reasoning behind the 200ms value?

Maybe name it as a constant together with a comment?

We wait 200ms if the channel is full. Not sure what should be the exact value. Any thoughts?
Named it txnBatchChTimeout

Should we have the batch size-based (event driven) on top of time-based?
In case there is a lot of messages coming in as a burst.
What do you think?

Having event-based will cause issues because in order to validate transactions we take a lock on the state trie. Block production might suffer due to this.

dot/services.go

dot/network/config.go

dot/network/transaction.go

…dle-transaction

dot/network/mock_transaction_handler.go

Answered his query

# [0.6.0](v0.5.0...v0.6.0) (2021-12-03) ### Bug Fixes * **babe:** Fix extrinsic format in block. ([#1530](#1530)) ([1a03b2a](1a03b2a)) * **ci:** add missing go-version matrix to fix development branch CI ([#2037](#2037)) ([6babe76](6babe76)) * **cmd/cfg:** Use Babe Lead value from toml config ([#2032](#2032)) ([06aa3e3](06aa3e3)) * cmd/gossamer: Generate random name if --name flag not set ([#1506](#1506)) ([3c05a88](3c05a88)) * confirm block import notifier is closed properly ([#1736](#1736)) ([ad2d85e](ad2d85e)) * **docs:** improve build-spec usage docs ([#1706](#1706)) ([2e164b4](2e164b4)) * **dot/core:** Add only extrinsic during chain reorg. ([#1609](#1609)) ([29413d4](29413d4)) * **dot/core:** Batch process transaction message. ([#1780](#1780)) ([0064836](0064836)) * **dot/core:** check transaction Validity.Propagate field to determine whether to propagate tx ([#1643](#1643)) ([81f23cc](81f23cc)) * **dot/core:** Fix handle transaction message test. ([#1607](#1607)) ([58b8725](58b8725)) * **dot/network, lib/grandpa:** fix handshake decoding and grandpa message handler sigabort ([#1631](#1631)) ([887f72c](887f72c)) * **dot/network, lib/grandpa:** fix node sync, improve devnet finality ([bcc7935](bcc7935)) * **dot/network:** add nil checks in connManager ([#2069](#2069)) ([7f9c042](7f9c042)) * **dot/network:** Check for size when decoding leb128. ([#1634](#1634)) ([d082b9e](d082b9e)) * **dot/network:** check if peer supports protocol ([#1617](#1617)) ([6bf66a4](6bf66a4)) * **dot/network:** decrease DHT find peers interval for gssmr nodes ([#1703](#1703)) ([08516a0](08516a0)) * **dot/network:** fix bugs in notifications protocol handlers; add metrics for inbound/outbound streams ([#2010](#2010)) ([8c2993d](8c2993d)) * **dot/network:** fix dht connection on discovery on devnet ([#2059](#2059)) ([da065b8](da065b8)) * **dot/network:** fix discovery between gossamer nodes ([#1594](#1594)) ([f4c79d3](f4c79d3)) * **dot/network:** fix justification request at head logic ([#1510](#1510)) ([98d1413](98d1413)) * **dot/network:** fix memory allocations with `sizedBufferPool` ([#1963](#1963)) ([e0b126b](e0b126b)) * **dot/network:** Fix missing digest in header ([#2092](#2092)) ([21ea85e](21ea85e)) * **dot/network:** Fix notification handshake and reuse stream. ([#1545](#1545)) ([a632dc4](a632dc4)) * **dot/network:** fix receiving notifications messages from substrate peers ([#1517](#1517)) ([fdf3c53](fdf3c53)) * **dot/network:** fix stream manager tests ([#1683](#1683)) ([e02eca4](e02eca4)) * **dot/network:** implement a handshake timeout ([#1615](#1615)) ([87c2f63](87c2f63)) * **dot/network:** Implement time based handle transaction ([#1942](#1942)) ([dd08424](dd08424)) * **dot/network:** move low reputation peer removal from network ConnManager to peer scoring logic (dot/peerstate) ([#2068](#2068)) ([ac16285](ac16285)), closes [#2039](#2039) * **dot/network:** Return on EOF error while reading stream. ([#1733](#1733)) ([f447eac](f447eac)) * **dot/network:** split stored streams and handshakeData into inbound and outbound ([#1553](#1553)) ([637050b](637050b)) * **dot/network:** update notificationsProtocol handshakeData to sync.Map ([#1492](#1492)) ([22f7269](22f7269)) * **dot/node:** Start websocket server only with `--ws` flag ([#1671](#1671)) ([6ecef3b](6ecef3b)) * **dot/state, lib/babe, lib/trie:** improve syncing between gossamer authority nodes ([#1613](#1613)) ([ca99fbf](ca99fbf)) * **dot/state, lib/grandpa:** update justification and SignedVote handling in database ([#1682](#1682)) ([bbdcd6f](bbdcd6f)) * **dot/state,dot/network:** improve memory usage when syncing ([#1491](#1491)) ([3b2ad8d](3b2ad8d)) * **dot/state:** add StorageState Lock/Unlock API for usage by babe and sync ([#1700](#1700)) ([3c22ace](3c22ace)) * **dot/state:** fix deadlock, fixes bootstrap syncing ([#1959](#1959)) ([dd80c09](dd80c09)) * **dot/state:** fix usage of trie.Snapshot ([#1489](#1489)) ([3880a40](3880a40)) * **dot/state:** track runtime per-block, fix runtime upgrades differing between forks ([#1638](#1638)) ([e133884](e133884)) * **dot/state:** update `*state.BlockState.AddBlockToBlockTree` to store block in `unfinalisedBlocksMap` ([#2006](#2006)) ([55d997f](55d997f)) * **dot/sync:** add nil header checks ([#2099](#2099)) ([a7d4be0](a7d4be0)) * **dot/sync:** fix block request and response logic ([#1907](#1907)) ([9c6283e](9c6283e)) * **dot/sync:** fix creating block response, fixes node sync between gossamer nodes ([#1572](#1572)) ([1328c80](1328c80)) * **dot/telemetry:** refactor telemetry to reduce CPU usage ([#1597](#1597)) ([bc31ac7](bc31ac7)) * **dot/types:** *types.Body to be of type []types.Extrinsic ([#1807](#1807)) ([4c09715](4c09715)) * **dot/types:** fix max value for digest ([#1687](#1687)) ([48405e7](48405e7)) * **dot:** fix `TestNewNode` ([#2070](#2070)) ([42908d0](42908d0)) * fix edit link ([#1507](#1507)) ([5089327](5089327)) * fix Kusama sync; add storageState lock in core.HandleTransactionMessage ([#1783](#1783)) ([1d688e4](1d688e4)) * **lib/babe, lib/runtime/wasmer:** fixes for v0.9.8+ runtime ([#2075](#2075)) ([2f9f80c](2f9f80c)) * **lib/babe:** add `--babe-lead` flag, update epoch handling logic ([#1895](#1895)) ([7abcce6](7abcce6)) * **lib/babe:** add pre-runtime digest before calling initialize_block ([#1581](#1581)) ([c1b26d3](c1b26d3)) * **lib/babe:** always use 2/3 of slot to produce block, re-add potentially valid txs to queue ([#1679](#1679)) ([cf93ad3](cf93ad3)) * **lib/babe:** call AddBlock in BABE synchronously ([#1585](#1585)) ([86acc43](86acc43)) * **lib/babe:** fix BABE state storing after building block ([#1536](#1536)) ([1a3dea2](1a3dea2)) * **lib/babe:** fix err log ([#1801](#1801)) ([a96f06a](a96f06a)) * **lib/babe:** fix setting first slot of network, fix loading BABE epoch params ([#1640](#1640)) ([5c3dbfe](5c3dbfe)) * **lib/babe:** fix timing for transition between epochs ([#1636](#1636)) ([57027db](57027db)) * **lib/blocktree:** fix blocktree bug ([#2060](#2060)) ([c17b53a](c17b53a)) * **lib/blocktree:** fix potential nil pointer dereference in `HighestCommonAncestor`, core `handleBlocksAsync` ([#1993](#1993)) ([f7f4463](f7f4463)) * **lib/blocktree:** fix setting leaves after blocktree pruning ([#1605](#1605)) ([58c0854](58c0854)) * **lib/blocktree:** removes the inconsistency to choose a deepest leaf ([#2094](#2094)) ([43d68e3](43d68e3)) * **lib/crypto/ed25519:** update ed25519 to use go-schnorrkel bip39 derivation ([#1488](#1488)) ([dfb95d2](dfb95d2)) * **lib/genesis:** Update missing and incorrect fields in genesis file. ([#1681](#1681)) ([8207704](8207704)) * **lib/grandpa:** fix grandpa stall and various bugs ([#1708](#1708)) ([67c93f4](67c93f4)) * **lib/grandpa:** fix grandpa vote message switch ([#2095](#2095)) ([461890c](461890c)) * **lib/grandpa:** fix threshold checking to be strictly greater than 2/3 ([#1891](#1891)) ([66ffe51](66ffe51)) * **lib/grandpa:** use `defaultGrandpaInterval` if not set, fixes error on startup ([#1982](#1982)) ([75627b5](75627b5)) * **lib/runtime/life:** remove import C from life ([#1923](#1923)) ([ed507d2](ed507d2)) * **lib/runtime:** update HOST_API_TEST_RUNTIME_URL to reference specific commit ([#1885](#1885)) ([666ed06](666ed06)) * **log-levels:** do not ignore configuration file log levels ([#2016](#2016)) ([80879b2](80879b2)) * pending bubble hidden after block included ([#1592](#1592)) ([5826322](5826322)) * persist node name ([#1543](#1543)) ([88b88f2](88b88f2)) * **pprof:** only run pprof service if enabled ([#2073](#2073)) ([55669c5](55669c5)) * **release:** Trigger release when pushed to main branch. ([#1566](#1566)) ([d445c97](d445c97)) * **rpc/subscription:** subscribe runtime version notify when version changes ([#1686](#1686)) ([9a76d39](9a76d39)) * Staging CI workflow ([#2034](#2034)) ([84ec792](84ec792)) * **trie:** memory leak fix in `lib/trie` ([#2009](#2009)) ([0ad5eb7](0ad5eb7)) * update deprecated package ([#1603](#1603)) ([f195204](f195204)) * update go-schnorrkel version ([#1557](#1557)) ([b86c7ff](b86c7ff)) * update gssmr genesis to use pallet_babe::SameAuthoritiesForever ([#1696](#1696)) ([fb0a751](fb0a751)) * update HOST_API_TEST_RUNTIME_URL ([#1898](#1898)) ([2ef59a8](2ef59a8)) * **utils:** create a specific folder for database ([#1598](#1598)) ([8c67795](8c67795)) ### Features * add --chain dev option ([#1561](#1561)) ([04a2969](04a2969)) * Add properties and chainId on build-spec command ([#1520](#1520)) ([b18290c](b18290c)) * cmd: implement import-runtime subcommand ([#1483](#1483)) ([d82b2da](d82b2da)) * **cmd/gossamer:** implement --telemetry-url parameter ([#1890](#1890)) ([b202e89](b202e89)), closes [#1502](#1502) * **cmd:** implement offline pruning of state trie ([#1564](#1564)) ([af9c925](af9c925)) * **devnet:** Local Gossamer Devnet ([#2008](#2008)) ([a520001](a520001)) * **dot/network, lib/grandpa:** request justification on receiving NeighbourMessage, verify justification on receipt ([#1529](#1529)) ([e1f9f42](e1f9f42)) * **dot/network:** Add cache for network message. ([#1511](#1511)) ([accaf69](accaf69)) * **dot/network:** add propagate return bool to messageHandler func type to determine whether to propagate message or not ([#1555](#1555)) ([0d6f488](0d6f488)) * **dot/network:** implement persistent peers functionality ([#1512](#1512)) ([7850532](7850532)) * **dot/network:** implement streamManager to cleanup not recently used streams ([#1611](#1611)) ([ba861bf](ba861bf)) * **dot/network:** request block justifications when near head ([#1499](#1499)) ([ae7012b](ae7012b)) * **dot/peerset:** Implement peer scoring ([#1791](#1791)) ([1c989ad](1c989ad)) * **dot/rpc/modules:** add `system_addReservedPeer` and `system_removeReservedPeer` RPC call ([#1712](#1712)) ([dba5922](dba5922)) * **dot/rpc:** Add `system_localListenAddresses` RPC call ([#1689](#1689)) ([c981d2e](c981d2e)) * **dot/rpc:** Implement `childstate_getKeys` rpc call ([#1800](#1800)) ([9b2f41e](9b2f41e)) * **dot/rpc:** implement sync_state_genSyncSpec RPC call ([#1827](#1827)) ([2186caf](2186caf)) * **dot/state:** implement online pruning of historical state tries ([#1596](#1596)) ([3eb9399](3eb9399)) * **dot/sync:** implement codeSubstitutes ([#1635](#1635)) ([d87aaeb](d87aaeb)) * dot/telemetry: Implement basic telemetry connection ([#1497](#1497)) ([fcb4159](fcb4159)) * **dot/telemetry:** Added connection retry ([#1904](#1904)) ([579a791](579a791)) * **dot/telemetry:** Added more telemetry messages in grandpa client ([#2043](#2043)) ([2e57d15](2e57d15)), closes [#1841](#1841) [#1842](#1842) * **dot/telemetry:** implement notify.finalized telemetry interface ([#1877](#1877)) ([de1a60d](de1a60d)) * **dot/telemetry:** implement substrate_number_leaves metrics ([#1926](#1926)) ([69823c0](69823c0)) * **dot/telemetry:** implement telemetry message network_state ([#1618](#1618)) ([a81844e](a81844e)) * **flags:** read log levels from flags ([#1953](#1953)) ([9694e46](9694e46)) * implement ext_default_child_storage_storage_kill_version_2 ([#1799](#1799)) ([c2908ae](c2908ae)) * implement ext_offchain_index_set_version_1 for wasmer runtime ([#1739](#1739)) ([96c30a6](96c30a6)) * **lib/babe:** add check of types.ConfigData.SecondarySlots for disabling secondary verification ([#1910](#1910)) ([cd27ae4](cd27ae4)) * **lib/grandpa:** fully verify justifications using GrandpaState ([#1544](#1544)) ([028d25e](028d25e)) * **lib/grandpa:** Include equivocatory nodes while creating justification ([#1911](#1911)) ([aca86b6](aca86b6)) * **lib/grandpa:** send NeighbourMessage to peers ([#1558](#1558)) ([322ccf9](322ccf9)) * **lib/runtime/wasmer:** implement ext_default_child_storage_storage_kill_version_3 ([#1878](#1878)) ([a719a60](a719a60)) * **lib/runtime/wasmer:** implement ext_offchain_local_storage_version_1 ([#1821](#1821)) ([0f63b17](0f63b17)) * **lib/runtime:** Implement `ext_offchain_http_request_add_header_version_1` host function ([#1994](#1994)) ([0a30b3d](0a30b3d)) * **lib/runtime:** Implement `ext_offchain_http_request_start_version_1` host function ([#1947](#1947)) ([974b1fc](974b1fc)) * **lib/runtime:** Implement `trie_blake2_256_verify_proof` host function ([#1920](#1920)) ([506565d](506565d)) * **lib/trie:** Implement `verify_proof` function ([#1883](#1883)) ([67bb5ef](67bb5ef)) * **lib/trie:** Implement limit for trie.ClearPrefix ([#1905](#1905)) ([becec9e](becec9e)) * **lib/trie:** Parallel hash trie. ([#1657](#1657)) ([22827e7](22827e7)) * **pprof:** Pprof HTTP server service ([#1991](#1991)) ([ce24ea9](ce24ea9)) * **rpc/subscription:** implement state_unsubscribeStorage ([#1574](#1574)) ([7574f10](7574f10)) * **rpc:** Implement `childstate_getChildStorage` RPC call ([#1832](#1832)) ([3d949f2](3d949f2)) * **rpc:** Implement `childstate_getStorageHash` RPC call ([#1805](#1805)) ([e539bd3](e539bd3)) * **rpc:** Implement `childstate_getStorageSize` RPC call ([#1810](#1810)) ([a04deb6](a04deb6)) * **rpc:** Implement `payment_queryInfo` RPC call ([#1826](#1826)) ([7a5deec](7a5deec)) * **rpc:** Implement `state_getReadProof` rpc call ([#1768](#1768)) ([865f80f](865f80f)) * **runtime:** implement custom logging handler that print function name ([#1825](#1825)) ([2b1276d](2b1276d)) * **telemetry:** send telemetry messages when GRANDPA receieves commit or vote messages ([#2015](#2015)) ([7bf40e1](7bf40e1)), closes [#1840](#1840) [#1839](#1839) [#1838](#1838) * **telemetry:** send txpool.import telemetry msg ([#1966](#1966)) ([ffc81bf](ffc81bf)) ### Reverts * Revert "feat(dot/rpc) implement `author_hasSessionKeys` RPC call (#1704)" (#1714) ([65380fd](65380fd)), closes [#1704](#1704) [#1714](#1714)

github-actions · 2021-12-03T21:03:53Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…1942) * Implement time-based batch processing of transaction messages.

arijitAD force-pushed the time-based-handle-transaction branch from c883b74 to 6e5e885 Compare November 2, 2021 11:14

arijitAD changed the title ~~fix(dot/network): Implement time based handle transaction.~~ fix(dot/network): Implement time based handle transaction Nov 2, 2021

arijitAD marked this pull request as ready for review November 2, 2021 15:29

arijitAD requested review from EclesioMeloJunior, edwardmack, jimjbrettj, kishansagathiya, noot, omar391 and timwu20 as code owners November 2, 2021 15:29

noot reviewed Nov 3, 2021

View reviewed changes

EclesioMeloJunior reviewed Nov 4, 2021

View reviewed changes

dot/network/transaction.go Outdated Show resolved Hide resolved

Implement time based batch processing of transcation message.

9384f18

arijitAD force-pushed the time-based-handle-transaction branch from 6e5e885 to 9384f18 Compare November 8, 2021 07:19

jimjbrettj reviewed Nov 8, 2021

View reviewed changes

Address comments.

5df9fe6

arijitAD requested review from EclesioMeloJunior, jimjbrettj and noot November 9, 2021 13:09

noot approved these changes Nov 10, 2021

View reviewed changes

dot/network/transaction.go Outdated Show resolved Hide resolved

arijitAD added 2 commits November 10, 2021 23:01

Fix failing tests.

37af18d

Address comments.

e90aed8

EclesioMeloJunior requested changes Nov 11, 2021

View reviewed changes

Address comments.

14e6563

arijitAD requested a review from EclesioMeloJunior November 11, 2021 16:53

EclesioMeloJunior previously requested changes Nov 11, 2021

View reviewed changes

dot/network/transaction.go Outdated Show resolved Hide resolved

arijitAD added 2 commits November 12, 2021 17:59

Merge remote-tracking branch 'origin/development' into time-based-han…

96de6ff

…dle-transaction

Fix build

bbe1b89

qdm12 reviewed Nov 12, 2021

View reviewed changes

arijitAD added 4 commits November 23, 2021 14:55

Address comments

61910bc

Merge remote-tracking branch 'origin/development' into time-based-han…

0fb0be2

…dle-transaction

Address lint issues

85fc57d

Minor nit

45d69c2

arijitAD requested review from qdm12, EclesioMeloJunior and noot November 23, 2021 09:50

qdm12 reviewed Nov 23, 2021

View reviewed changes

Increase slot duration time in test

464f2bc

arijitAD mentioned this pull request Nov 23, 2021

Investigate if the slot duration time in test can be reduced. #2064

Open

Address comments

07f1a35

qdm12 reviewed Nov 25, 2021

View reviewed changes

dot/network/config.go Outdated Show resolved Hide resolved

dot/network/transaction.go Outdated Show resolved Hide resolved

dot/network/transaction.go Outdated Show resolved Hide resolved

arijitAD added 2 commits November 26, 2021 17:48

Merge remote-tracking branch 'origin/development' into time-based-han…

85d1620

…dle-transaction

Address comments.

3dd07ab

omar391 removed their request for review November 26, 2021 12:21

Fix mock

993b423

qdm12 approved these changes Nov 26, 2021

View reviewed changes

dot/network/mock_transaction_handler.go Outdated Show resolved Hide resolved

arijitAD added 2 commits November 26, 2021 18:00

Fix mock

a5dcfde

Fix lint

a297154

arijitAD merged commit dd08424 into development Nov 26, 2021

arijitAD deleted the time-based-handle-transaction branch November 26, 2021 13:26

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021

fix(dot/network): Implement time based handle transaction (ChainSafe#…

72455d1

…1942) * Implement time-based batch processing of transaction messages.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dot/network): Implement time based handle transaction #1942

fix(dot/network): Implement time based handle transaction #1942

arijitAD commented Oct 29, 2021 •

edited

Loading

noot Nov 3, 2021

arijitAD Nov 9, 2021

noot Nov 3, 2021

arijitAD Nov 9, 2021

codecov bot commented Nov 8, 2021 •

edited

Loading

jimjbrettj Nov 8, 2021

noot Nov 8, 2021

jimjbrettj Nov 8, 2021

arijitAD Nov 9, 2021

noot Nov 10, 2021

noot left a comment

EclesioMeloJunior Nov 11, 2021

arijitAD Nov 11, 2021

EclesioMeloJunior Nov 11, 2021

arijitAD Nov 11, 2021

qdm12 Nov 23, 2021

arijitAD Nov 24, 2021

qdm12 Nov 25, 2021

arijitAD Nov 26, 2021

github-actions bot commented Dec 3, 2021

		@@ -58,7 +58,7 @@ type (
		NotificationsMessageHandler = func(peer peer.ID, msg NotificationsMessage) (propagate bool, err error)

		// NotificationsMessageBatchHandler is called when a (non-handshake) message is received over a notifications stream in batch processing mode.

fix(dot/network): Implement time based handle transaction #1942

fix(dot/network): Implement time based handle transaction #1942

Conversation

arijitAD commented Oct 29, 2021 • edited Loading

Changes

Tests

Issues

Primary Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 8, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2021

arijitAD commented Oct 29, 2021 •

edited

Loading

codecov bot commented Nov 8, 2021 •

edited

Loading