fix(dot/network): fix dht connection on discovery on devnet #2059

kishansagathiya · 2021-11-22T15:38:37Z

Changes

We had a limit on number on ingoing and outgoing connections (maxOut and maxIn in peerset.Info). The limit on incoming connection was 2. Thus when we tried with a 3 node dev net, the first node was able to connect with both remaining nodes. Since, we were bootstrapping using address of the first node, it only received incoming connection. Since the limit there was 2 we did not see the problem.
For remaining two nodes, they were able to connect with only one peer (first node), since they had to send outgoing connection request, limit for which was 1.
For creating these limits we were using number of min peers and max peers from network config. This PR sets max peers in network config to 100 (I don't if that if an appropriate value). number of min peers was being used as limit for outgoing connection, I have changed that to number of max peers, so that nodes will be able to send a lot more outgoing requests. (Any arguments for why this should not be allowed?)

Tests

Run a dev net with 3 gossamer nodes on different machines with public IP (not behind nat). Use https://hackmd.io/@nZ-twauPRISEa6G9zg3XRw/B1RFO3uDt for that. From the logs (block import messages), you would see that all nodes have two peers.

Issues

Closes fix DHT connection on discovery on devnet #2026

Primary Reviewer

@noot

cmd/gossamer/config.go

dot/network/discovery.go

dot/network/service.go

dot/peerset/peerset.go

dot/peerset/peerstate.go

noot · 2021-11-24T19:18:07Z

dot/network/discovery.go

+				// TODO: This fails consistently.
+				logger.Warnf("failed to advertise in the DHT: %s", err)


i think we can probably remove the error log or change it do debug, as when you start the first node and it has no peers, this will always error

this will always error

For some time until another node is up right? Maybe we can have it as info with something less dramatic than failed such as

Suggested change

// TODO: This fails consistently.

logger.Warnf("failed to advertise in the DHT: %s", err)

logger.Infof("cannot advertise in the DHT: %s", err)

i think we can probably remove the error log or change it do debug, as when you start the first node and it has no peers, this will always error

I just tried a dev network with 3 nodes. I saw it only in the beginning.

I will remove my comment This fails consistently.

We advertise in the DHT at regular intervals, so we shouldn't remove this log. During the first time it says that there are no peers in the table (so anyone looking at the logs, would know to avoid it). This warning does not show after that.

I would rather have this warning in case this fails for any other reason, than have that error hidden in the debug mode.

@noot should i still change?

I'm fine to leave it as-is for now

dot/network/service.go

chain/gssmr/defaults.go

dot/network/host.go

dot/peerset/peerstate.go

noot

works for me :D nice work, just a few comments!

qdm12 · 2021-11-26T13:31:41Z

dot/network/discovery.go

+				// TODO: This fails consistently.
+				logger.Warnf("failed to advertise in the DHT: %s", err)


this will always error

For some time until another node is up right? Maybe we can have it as info with something less dramatic than failed such as

Suggested change

// TODO: This fails consistently.

logger.Warnf("failed to advertise in the DHT: %s", err)

logger.Infof("cannot advertise in the DHT: %s", err)

dot/network/host.go

dot/peerset/peerset.go

dot/peerset/peerstate.go

codecov · 2021-11-30T16:18:03Z

Codecov Report

Merging #2059 (dba4a57) into development (ac16285) will increase coverage by 0.03%.
The diff coverage is 30.00%.

@@               Coverage Diff               @@
##           development    #2059      +/-   ##
===============================================
+ Coverage        60.57%   60.61%   +0.03%     
===============================================
  Files              202      204       +2     
  Lines            27284    27354      +70     
===============================================
+ Hits             16528    16580      +52     
- Misses            8849     8866      +17     
- Partials          1907     1908       +1

Flag	Coverage Δ
unit-tests	`60.61% <30.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/network/service.go	`57.74% <0.00%> (ø)`
dot/peerset/peerset.go	`49.88% <4.76%> (-4.92%)`	⬇️
dot/peerset/peerstate.go	`76.00% <57.14%> (-0.34%)`	⬇️
cmd/gossamer/config.go	`75.07% <100.00%> (ø)`
dot/config.go	`26.19% <100.00%> (+0.29%)`	⬆️
dot/network/discovery.go	`65.25% <100.00%> (+6.02%)`	⬆️
dot/network/host.go	`61.77% <100.00%> (+0.29%)`	⬆️
dot/peerset/test_helpers.go	`100.00% <100.00%> (ø)`
dot/network/connmgr.go	`89.04% <0.00%> (-1.37%)`	⬇️
lib/blocktree/blocktree.go	`53.81% <0.00%> (-1.10%)`	⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac16285...dba4a57. Read the comment docs.

dot/peerset/peerstate.go

dot/peerset/test_helpers.go

dot/peerset/peerstate.go

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>

dot/peerset/peerstate.go

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

EclesioMeloJunior · 2021-12-02T11:46:33Z

dot/peerset/peerstate.go

@@ -237,17 +238,17 @@ func (ps *PeersState) hasFreeIncomingSlot(set int) bool {

 // addNoSlotNode adds a node to the list of nodes that don't occupy slots.
 // has no effect if the node was already in the group.
-func (ps *PeersState) addNoSlotNode(idx int, peerID peer.ID) {
+func (ps *PeersState) addNoSlotNode(idx int, peerID peer.ID) error {


could we add a condition if idx >= len(ps.sets) then return an error? it could not happen but just to adopt a kind of defensive programming.

EclesioMeloJunior · 2021-12-02T11:47:30Z

dot/peerset/peerstate.go

@@ -258,17 +259,19 @@ func (ps *PeersState) addNoSlotNode(idx int, peerID peer.ID) {
 	}


just a question: numIn and numOut can achieve negative values? @arijitAD

numIn: number of connections where other nodes connected to us
numOut: number of connections where we connected to other nodes

don't think these values could be negative

ok, should we add some sort of check to avoid these values being negatives?

EclesioMeloJunior · 2021-12-02T11:48:27Z

dot/peerset/peerstate.go

 	if _, ok := ps.sets[idx].noSlotNodes[peerID]; !ok {
-		return
+		logger.Debugf("peer %s is not in no-slot node map", peerID)


same condition to check if the idx is in the boundaries of ps.sets

need to merge this

# [0.6.0](v0.5.0...v0.6.0) (2021-12-03) ### Bug Fixes * **babe:** Fix extrinsic format in block. ([#1530](#1530)) ([1a03b2a](1a03b2a)) * **ci:** add missing go-version matrix to fix development branch CI ([#2037](#2037)) ([6babe76](6babe76)) * **cmd/cfg:** Use Babe Lead value from toml config ([#2032](#2032)) ([06aa3e3](06aa3e3)) * cmd/gossamer: Generate random name if --name flag not set ([#1506](#1506)) ([3c05a88](3c05a88)) * confirm block import notifier is closed properly ([#1736](#1736)) ([ad2d85e](ad2d85e)) * **docs:** improve build-spec usage docs ([#1706](#1706)) ([2e164b4](2e164b4)) * **dot/core:** Add only extrinsic during chain reorg. ([#1609](#1609)) ([29413d4](29413d4)) * **dot/core:** Batch process transaction message. ([#1780](#1780)) ([0064836](0064836)) * **dot/core:** check transaction Validity.Propagate field to determine whether to propagate tx ([#1643](#1643)) ([81f23cc](81f23cc)) * **dot/core:** Fix handle transaction message test. ([#1607](#1607)) ([58b8725](58b8725)) * **dot/network, lib/grandpa:** fix handshake decoding and grandpa message handler sigabort ([#1631](#1631)) ([887f72c](887f72c)) * **dot/network, lib/grandpa:** fix node sync, improve devnet finality ([bcc7935](bcc7935)) * **dot/network:** add nil checks in connManager ([#2069](#2069)) ([7f9c042](7f9c042)) * **dot/network:** Check for size when decoding leb128. ([#1634](#1634)) ([d082b9e](d082b9e)) * **dot/network:** check if peer supports protocol ([#1617](#1617)) ([6bf66a4](6bf66a4)) * **dot/network:** decrease DHT find peers interval for gssmr nodes ([#1703](#1703)) ([08516a0](08516a0)) * **dot/network:** fix bugs in notifications protocol handlers; add metrics for inbound/outbound streams ([#2010](#2010)) ([8c2993d](8c2993d)) * **dot/network:** fix dht connection on discovery on devnet ([#2059](#2059)) ([da065b8](da065b8)) * **dot/network:** fix discovery between gossamer nodes ([#1594](#1594)) ([f4c79d3](f4c79d3)) * **dot/network:** fix justification request at head logic ([#1510](#1510)) ([98d1413](98d1413)) * **dot/network:** fix memory allocations with `sizedBufferPool` ([#1963](#1963)) ([e0b126b](e0b126b)) * **dot/network:** Fix missing digest in header ([#2092](#2092)) ([21ea85e](21ea85e)) * **dot/network:** Fix notification handshake and reuse stream. ([#1545](#1545)) ([a632dc4](a632dc4)) * **dot/network:** fix receiving notifications messages from substrate peers ([#1517](#1517)) ([fdf3c53](fdf3c53)) * **dot/network:** fix stream manager tests ([#1683](#1683)) ([e02eca4](e02eca4)) * **dot/network:** implement a handshake timeout ([#1615](#1615)) ([87c2f63](87c2f63)) * **dot/network:** Implement time based handle transaction ([#1942](#1942)) ([dd08424](dd08424)) * **dot/network:** move low reputation peer removal from network ConnManager to peer scoring logic (dot/peerstate) ([#2068](#2068)) ([ac16285](ac16285)), closes [#2039](#2039) * **dot/network:** Return on EOF error while reading stream. ([#1733](#1733)) ([f447eac](f447eac)) * **dot/network:** split stored streams and handshakeData into inbound and outbound ([#1553](#1553)) ([637050b](637050b)) * **dot/network:** update notificationsProtocol handshakeData to sync.Map ([#1492](#1492)) ([22f7269](22f7269)) * **dot/node:** Start websocket server only with `--ws` flag ([#1671](#1671)) ([6ecef3b](6ecef3b)) * **dot/state, lib/babe, lib/trie:** improve syncing between gossamer authority nodes ([#1613](#1613)) ([ca99fbf](ca99fbf)) * **dot/state, lib/grandpa:** update justification and SignedVote handling in database ([#1682](#1682)) ([bbdcd6f](bbdcd6f)) * **dot/state,dot/network:** improve memory usage when syncing ([#1491](#1491)) ([3b2ad8d](3b2ad8d)) * **dot/state:** add StorageState Lock/Unlock API for usage by babe and sync ([#1700](#1700)) ([3c22ace](3c22ace)) * **dot/state:** fix deadlock, fixes bootstrap syncing ([#1959](#1959)) ([dd80c09](dd80c09)) * **dot/state:** fix usage of trie.Snapshot ([#1489](#1489)) ([3880a40](3880a40)) * **dot/state:** track runtime per-block, fix runtime upgrades differing between forks ([#1638](#1638)) ([e133884](e133884)) * **dot/state:** update `*state.BlockState.AddBlockToBlockTree` to store block in `unfinalisedBlocksMap` ([#2006](#2006)) ([55d997f](55d997f)) * **dot/sync:** add nil header checks ([#2099](#2099)) ([a7d4be0](a7d4be0)) * **dot/sync:** fix block request and response logic ([#1907](#1907)) ([9c6283e](9c6283e)) * **dot/sync:** fix creating block response, fixes node sync between gossamer nodes ([#1572](#1572)) ([1328c80](1328c80)) * **dot/telemetry:** refactor telemetry to reduce CPU usage ([#1597](#1597)) ([bc31ac7](bc31ac7)) * **dot/types:** *types.Body to be of type []types.Extrinsic ([#1807](#1807)) ([4c09715](4c09715)) * **dot/types:** fix max value for digest ([#1687](#1687)) ([48405e7](48405e7)) * **dot:** fix `TestNewNode` ([#2070](#2070)) ([42908d0](42908d0)) * fix edit link ([#1507](#1507)) ([5089327](5089327)) * fix Kusama sync; add storageState lock in core.HandleTransactionMessage ([#1783](#1783)) ([1d688e4](1d688e4)) * **lib/babe, lib/runtime/wasmer:** fixes for v0.9.8+ runtime ([#2075](#2075)) ([2f9f80c](2f9f80c)) * **lib/babe:** add `--babe-lead` flag, update epoch handling logic ([#1895](#1895)) ([7abcce6](7abcce6)) * **lib/babe:** add pre-runtime digest before calling initialize_block ([#1581](#1581)) ([c1b26d3](c1b26d3)) * **lib/babe:** always use 2/3 of slot to produce block, re-add potentially valid txs to queue ([#1679](#1679)) ([cf93ad3](cf93ad3)) * **lib/babe:** call AddBlock in BABE synchronously ([#1585](#1585)) ([86acc43](86acc43)) * **lib/babe:** fix BABE state storing after building block ([#1536](#1536)) ([1a3dea2](1a3dea2)) * **lib/babe:** fix err log ([#1801](#1801)) ([a96f06a](a96f06a)) * **lib/babe:** fix setting first slot of network, fix loading BABE epoch params ([#1640](#1640)) ([5c3dbfe](5c3dbfe)) * **lib/babe:** fix timing for transition between epochs ([#1636](#1636)) ([57027db](57027db)) * **lib/blocktree:** fix blocktree bug ([#2060](#2060)) ([c17b53a](c17b53a)) * **lib/blocktree:** fix potential nil pointer dereference in `HighestCommonAncestor`, core `handleBlocksAsync` ([#1993](#1993)) ([f7f4463](f7f4463)) * **lib/blocktree:** fix setting leaves after blocktree pruning ([#1605](#1605)) ([58c0854](58c0854)) * **lib/blocktree:** removes the inconsistency to choose a deepest leaf ([#2094](#2094)) ([43d68e3](43d68e3)) * **lib/crypto/ed25519:** update ed25519 to use go-schnorrkel bip39 derivation ([#1488](#1488)) ([dfb95d2](dfb95d2)) * **lib/genesis:** Update missing and incorrect fields in genesis file. ([#1681](#1681)) ([8207704](8207704)) * **lib/grandpa:** fix grandpa stall and various bugs ([#1708](#1708)) ([67c93f4](67c93f4)) * **lib/grandpa:** fix grandpa vote message switch ([#2095](#2095)) ([461890c](461890c)) * **lib/grandpa:** fix threshold checking to be strictly greater than 2/3 ([#1891](#1891)) ([66ffe51](66ffe51)) * **lib/grandpa:** use `defaultGrandpaInterval` if not set, fixes error on startup ([#1982](#1982)) ([75627b5](75627b5)) * **lib/runtime/life:** remove import C from life ([#1923](#1923)) ([ed507d2](ed507d2)) * **lib/runtime:** update HOST_API_TEST_RUNTIME_URL to reference specific commit ([#1885](#1885)) ([666ed06](666ed06)) * **log-levels:** do not ignore configuration file log levels ([#2016](#2016)) ([80879b2](80879b2)) * pending bubble hidden after block included ([#1592](#1592)) ([5826322](5826322)) * persist node name ([#1543](#1543)) ([88b88f2](88b88f2)) * **pprof:** only run pprof service if enabled ([#2073](#2073)) ([55669c5](55669c5)) * **release:** Trigger release when pushed to main branch. ([#1566](#1566)) ([d445c97](d445c97)) * **rpc/subscription:** subscribe runtime version notify when version changes ([#1686](#1686)) ([9a76d39](9a76d39)) * Staging CI workflow ([#2034](#2034)) ([84ec792](84ec792)) * **trie:** memory leak fix in `lib/trie` ([#2009](#2009)) ([0ad5eb7](0ad5eb7)) * update deprecated package ([#1603](#1603)) ([f195204](f195204)) * update go-schnorrkel version ([#1557](#1557)) ([b86c7ff](b86c7ff)) * update gssmr genesis to use pallet_babe::SameAuthoritiesForever ([#1696](#1696)) ([fb0a751](fb0a751)) * update HOST_API_TEST_RUNTIME_URL ([#1898](#1898)) ([2ef59a8](2ef59a8)) * **utils:** create a specific folder for database ([#1598](#1598)) ([8c67795](8c67795)) ### Features * add --chain dev option ([#1561](#1561)) ([04a2969](04a2969)) * Add properties and chainId on build-spec command ([#1520](#1520)) ([b18290c](b18290c)) * cmd: implement import-runtime subcommand ([#1483](#1483)) ([d82b2da](d82b2da)) * **cmd/gossamer:** implement --telemetry-url parameter ([#1890](#1890)) ([b202e89](b202e89)), closes [#1502](#1502) * **cmd:** implement offline pruning of state trie ([#1564](#1564)) ([af9c925](af9c925)) * **devnet:** Local Gossamer Devnet ([#2008](#2008)) ([a520001](a520001)) * **dot/network, lib/grandpa:** request justification on receiving NeighbourMessage, verify justification on receipt ([#1529](#1529)) ([e1f9f42](e1f9f42)) * **dot/network:** Add cache for network message. ([#1511](#1511)) ([accaf69](accaf69)) * **dot/network:** add propagate return bool to messageHandler func type to determine whether to propagate message or not ([#1555](#1555)) ([0d6f488](0d6f488)) * **dot/network:** implement persistent peers functionality ([#1512](#1512)) ([7850532](7850532)) * **dot/network:** implement streamManager to cleanup not recently used streams ([#1611](#1611)) ([ba861bf](ba861bf)) * **dot/network:** request block justifications when near head ([#1499](#1499)) ([ae7012b](ae7012b)) * **dot/peerset:** Implement peer scoring ([#1791](#1791)) ([1c989ad](1c989ad)) * **dot/rpc/modules:** add `system_addReservedPeer` and `system_removeReservedPeer` RPC call ([#1712](#1712)) ([dba5922](dba5922)) * **dot/rpc:** Add `system_localListenAddresses` RPC call ([#1689](#1689)) ([c981d2e](c981d2e)) * **dot/rpc:** Implement `childstate_getKeys` rpc call ([#1800](#1800)) ([9b2f41e](9b2f41e)) * **dot/rpc:** implement sync_state_genSyncSpec RPC call ([#1827](#1827)) ([2186caf](2186caf)) * **dot/state:** implement online pruning of historical state tries ([#1596](#1596)) ([3eb9399](3eb9399)) * **dot/sync:** implement codeSubstitutes ([#1635](#1635)) ([d87aaeb](d87aaeb)) * dot/telemetry: Implement basic telemetry connection ([#1497](#1497)) ([fcb4159](fcb4159)) * **dot/telemetry:** Added connection retry ([#1904](#1904)) ([579a791](579a791)) * **dot/telemetry:** Added more telemetry messages in grandpa client ([#2043](#2043)) ([2e57d15](2e57d15)), closes [#1841](#1841) [#1842](#1842) * **dot/telemetry:** implement notify.finalized telemetry interface ([#1877](#1877)) ([de1a60d](de1a60d)) * **dot/telemetry:** implement substrate_number_leaves metrics ([#1926](#1926)) ([69823c0](69823c0)) * **dot/telemetry:** implement telemetry message network_state ([#1618](#1618)) ([a81844e](a81844e)) * **flags:** read log levels from flags ([#1953](#1953)) ([9694e46](9694e46)) * implement ext_default_child_storage_storage_kill_version_2 ([#1799](#1799)) ([c2908ae](c2908ae)) * implement ext_offchain_index_set_version_1 for wasmer runtime ([#1739](#1739)) ([96c30a6](96c30a6)) * **lib/babe:** add check of types.ConfigData.SecondarySlots for disabling secondary verification ([#1910](#1910)) ([cd27ae4](cd27ae4)) * **lib/grandpa:** fully verify justifications using GrandpaState ([#1544](#1544)) ([028d25e](028d25e)) * **lib/grandpa:** Include equivocatory nodes while creating justification ([#1911](#1911)) ([aca86b6](aca86b6)) * **lib/grandpa:** send NeighbourMessage to peers ([#1558](#1558)) ([322ccf9](322ccf9)) * **lib/runtime/wasmer:** implement ext_default_child_storage_storage_kill_version_3 ([#1878](#1878)) ([a719a60](a719a60)) * **lib/runtime/wasmer:** implement ext_offchain_local_storage_version_1 ([#1821](#1821)) ([0f63b17](0f63b17)) * **lib/runtime:** Implement `ext_offchain_http_request_add_header_version_1` host function ([#1994](#1994)) ([0a30b3d](0a30b3d)) * **lib/runtime:** Implement `ext_offchain_http_request_start_version_1` host function ([#1947](#1947)) ([974b1fc](974b1fc)) * **lib/runtime:** Implement `trie_blake2_256_verify_proof` host function ([#1920](#1920)) ([506565d](506565d)) * **lib/trie:** Implement `verify_proof` function ([#1883](#1883)) ([67bb5ef](67bb5ef)) * **lib/trie:** Implement limit for trie.ClearPrefix ([#1905](#1905)) ([becec9e](becec9e)) * **lib/trie:** Parallel hash trie. ([#1657](#1657)) ([22827e7](22827e7)) * **pprof:** Pprof HTTP server service ([#1991](#1991)) ([ce24ea9](ce24ea9)) * **rpc/subscription:** implement state_unsubscribeStorage ([#1574](#1574)) ([7574f10](7574f10)) * **rpc:** Implement `childstate_getChildStorage` RPC call ([#1832](#1832)) ([3d949f2](3d949f2)) * **rpc:** Implement `childstate_getStorageHash` RPC call ([#1805](#1805)) ([e539bd3](e539bd3)) * **rpc:** Implement `childstate_getStorageSize` RPC call ([#1810](#1810)) ([a04deb6](a04deb6)) * **rpc:** Implement `payment_queryInfo` RPC call ([#1826](#1826)) ([7a5deec](7a5deec)) * **rpc:** Implement `state_getReadProof` rpc call ([#1768](#1768)) ([865f80f](865f80f)) * **runtime:** implement custom logging handler that print function name ([#1825](#1825)) ([2b1276d](2b1276d)) * **telemetry:** send telemetry messages when GRANDPA receieves commit or vote messages ([#2015](#2015)) ([7bf40e1](7bf40e1)), closes [#1840](#1840) [#1839](#1839) [#1838](#1838) * **telemetry:** send txpool.import telemetry msg ([#1966](#1966)) ([ffc81bf](ffc81bf)) ### Reverts * Revert "feat(dot/rpc) implement `author_hasSessionKeys` RPC call (#1704)" (#1714) ([65380fd](65380fd)), closes [#1704](#1704) [#1714](#1714)

github-actions · 2021-12-03T21:02:47Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…e#2059)

kishansagathiya added 3 commits November 22, 2021 19:15

testing

74d1565

Merge branch 'development' into kishan/fix/dht

fbd98db

some cleanup

74e3fa5

kishansagathiya requested review from arijitAD, EclesioMeloJunior, edwardmack, jimjbrettj, noot, omar391 and timwu20 as code owners November 22, 2021 15:38

qdm12 reviewed Nov 23, 2021

View reviewed changes

noot reviewed Nov 24, 2021

View reviewed changes

dot/network/service.go Outdated Show resolved Hide resolved

noot reviewed Nov 24, 2021

View reviewed changes

dot/network/service.go Outdated Show resolved Hide resolved

noot reviewed Nov 25, 2021

View reviewed changes

chain/gssmr/defaults.go Outdated Show resolved Hide resolved

noot reviewed Nov 25, 2021

View reviewed changes

dot/network/host.go Outdated Show resolved Hide resolved

noot reviewed Nov 25, 2021

View reviewed changes

dot/peerset/peerstate.go Outdated Show resolved Hide resolved

noot reviewed Nov 25, 2021

View reviewed changes

kishansagathiya added 3 commits November 26, 2021 14:48

Merge branch 'development' into kishan/fix/dht

d32eb02

Addressed some reviews

270e0ba

Set max out going connection to half of max peers

8e32e93

qdm12 reviewed Nov 26, 2021

View reviewed changes

kishansagathiya added 7 commits November 29, 2021 15:50

Merge branch 'development' into kishan/fix/dht

0f0bb72

temp

b93df80

temp

00d7801

temp

a9b1737

Merge branch 'development' into kishan/fix/dht

e1346a7

fixed some tests and addressed reviews

a7d09c5

fix tests

3551308

qdm12 reviewed Nov 30, 2021

View reviewed changes

dot/peerset/peerstate.go Show resolved Hide resolved

dot/peerset/test_helpers.go Outdated Show resolved Hide resolved

kishansagathiya mentioned this pull request Nov 30, 2021

fix skipped tests #1026

Closed

16 tasks

kishansagathiya added 2 commits November 30, 2021 23:54

addressed more reviews

507f138

Merge branch 'development' into kishan/fix/dht

b001f27

kishansagathiya requested review from qdm12 and noot November 30, 2021 18:36

EclesioMeloJunior requested changes Nov 30, 2021

View reviewed changes

dot/peerset/peerstate.go Outdated Show resolved Hide resolved

Update dot/peerset/peerstate.go

33d3c64

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>

kishansagathiya requested a review from EclesioMeloJunior December 1, 2021 10:41

qdm12 approved these changes Dec 1, 2021

View reviewed changes

dot/peerset/peerstate.go Outdated Show resolved Hide resolved

dot/peerset/peerstate.go Outdated Show resolved Hide resolved

kishansagathiya and others added 2 commits December 1, 2021 21:04

Update dot/peerset/peerstate.go

50c66c2

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

Update dot/peerset/peerstate.go

dba4a57

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

EclesioMeloJunior previously requested changes Dec 2, 2021

View reviewed changes

noot approved these changes Dec 3, 2021

View reviewed changes

noot merged commit da065b8 into development Dec 3, 2021

noot deleted the kishan/fix/dht branch December 3, 2021 15:57

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021

fix(dot/network): fix dht connection on discovery on devnet (ChainSaf…

d9008aa

…e#2059)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dot/network): fix dht connection on discovery on devnet #2059

fix(dot/network): fix dht connection on discovery on devnet #2059

kishansagathiya commented Nov 22, 2021

noot Nov 24, 2021

qdm12 Nov 26, 2021

kishansagathiya Nov 30, 2021 •

edited

Loading

noot Dec 3, 2021

noot left a comment

qdm12 Nov 26, 2021

codecov bot commented Nov 30, 2021 •

edited

Loading

EclesioMeloJunior Dec 2, 2021

EclesioMeloJunior Dec 2, 2021

kishansagathiya Dec 2, 2021

EclesioMeloJunior Dec 2, 2021

EclesioMeloJunior Dec 2, 2021

github-actions bot commented Dec 3, 2021

		// TODO: This fails consistently.
		logger.Warnf("failed to advertise in the DHT: %s", err)

	// TODO: This fails consistently.
	logger.Warnf("failed to advertise in the DHT: %s", err)
	logger.Infof("cannot advertise in the DHT: %s", err)

		@@ -258,17 +259,19 @@ func (ps *PeersState) addNoSlotNode(idx int, peerID peer.ID) {
		}

fix(dot/network): fix dht connection on discovery on devnet #2059

fix(dot/network): fix dht connection on discovery on devnet #2059

Conversation

kishansagathiya commented Nov 22, 2021

Changes

Tests

Issues

Primary Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kishansagathiya Nov 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 30, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2021

kishansagathiya Nov 30, 2021 •

edited

Loading

codecov bot commented Nov 30, 2021 •

edited

Loading