fix(dot/network): fix dht connection on discovery on devnet

dot/network/connmgr_test.go

@@ -142,7 +142,7 @@ func TestPersistentPeers(t *testing.T) {
 	}
 	nodeB := createTestService(t, configB)
 
-	time.Sleep(time.Millisecond * 2000)
+	time.Sleep(time.Millisecond * 600)
 	// B should have connected to A during bootstrap
 	conns := nodeB.host.h.Network().ConnsToPeer(nodeA.host.id())
 	require.NotEqual(t, 0, len(conns))
@@ -226,13 +226,13 @@ func TestSetReservedPeer(t *testing.T) {
 
 	node3 := createTestService(t, config)
 	node3.noGossip = true
-	time.Sleep(time.Millisecond * 3000)
+	time.Sleep(time.Millisecond * 600)
 
 	require.Equal(t, 2, node3.host.peerCount())
 
 	node3.host.h.Peerstore().AddAddrs(addrC.ID, addrC.Addrs, peerstore.PermanentAddrTTL)
 	node3.host.cm.peerSetHandler.SetReservedPeer(0, addrC.ID)
-	time.Sleep(2000 * time.Millisecond)
+	time.Sleep(200 * time.Millisecond)
 
 	// reservedOnly mode is not yet implemented, so nodeA and nodeB won't be disconnected (#1888).
 	// TODO: once reservedOnly mode is implemented and reservedOnly is set to true, change expected value to 1 (nodeC)

dot/network/host_test.go

@@ -453,7 +453,7 @@ func Test_AddReservedPeers(t *testing.T) {
 	err := nodeA.host.addReservedPeers(nodeBPeerAddr)
 	require.NoError(t, err)
 
-	time.Sleep(1000 * time.Millisecond)
+	time.Sleep(100 * time.Millisecond)
 
 	require.Equal(t, 1, nodeA.host.peerCount())
 }
@@ -485,7 +485,7 @@ func Test_RemoveReservedPeers(t *testing.T) {
 	err := nodeA.host.addReservedPeers(nodeBPeerAddr)
 	require.NoError(t, err)
 
-	time.Sleep(1000 * time.Millisecond)
+	time.Sleep(100 * time.Millisecond)
 
 	require.Equal(t, 1, nodeA.host.peerCount())
 	pID := nodeB.host.addrInfo().ID.String()

dot/peerset/peerset.go

@@ -432,6 +432,8 @@ func (ps *PeerSet) addReservedPeers(setID int, peers ...peer.ID) error {
 			return nil
 		}
 
+		ps.peerState.discover(setID, peerID)
+
 		ps.reservedNode[peerID] = struct{}{}
 		if err := ps.peerState.addNoSlotNode(setID, peerID); err != nil {
 			return fmt.Errorf("could not add to list of no-slot nodes: %w", err)

dot/peerset/peerset_test.go

@@ -53,7 +53,7 @@ func TestAddReservedPeers(t *testing.T) {
 	handler.AddReservedPeer(0, reservedPeer)
 	handler.AddReservedPeer(0, reservedPeer2)
 
-	time.Sleep(time.Millisecond * 2000)
+	time.Sleep(time.Millisecond * 200)
 
 	expectedMsgs := []Message{
 		{Status: Connect, setID: 0, PeerID: bootNode},

dot/peerset/peerstate.go

@@ -249,7 +249,7 @@ func (ps *PeersState) addNoSlotNode(idx int, peerID peer.ID) error {
 	ps.sets[idx].noSlotNodes[peerID] = struct{}{}
 	n, err := ps.getNode(peerID)
 	if err != nil {
-		return fmt.Errorf("could not get node: %w", err)
+		return fmt.Errorf("could not get node for peer id %s: %w", peerID, err)
 	}
 
 	switch n.state[idx] {

dot/peerset/test_helpers.go

@@ -44,7 +44,7 @@ func newTestPeerSet(t *testing.T, in, out uint32, bootNodes, reservedPeers []pee
 
 	handler.AddPeer(0, bootNodes...)
 	handler.AddReservedPeer(0, reservedPeers...)
-	time.Sleep(time.Millisecond * 4000)
+	time.Sleep(time.Millisecond * 100)
 
 	return handler
 }