chore(lib/trie): add Deltas in internal/trie/tracking
#2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the base branch from
development
to
qdm12/trie/fix-deleted-keys
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
from
e0c6446
to
b72a7c6
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
80edf18
to
64e183d
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
from
b72a7c6
to
400a69e
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
64e183d
to
2389072
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
from
400a69e
to
2d2cf27
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
2389072
to
5b13219
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
2 times, most recently
from
105d1f7
to
ccb592a
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
3 times, most recently
from
4c54bd0
to
089fa9f
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
from
ccb592a
to
ce9ff3b
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
from
aebf0f1
to
4e60257
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
089fa9f
to
c0d828e
Compare
qdm12
force-pushed
the
qdm12/trie/fix-deleted-keys
branch
4 times, most recently
from
0d91179
to
c61ae90
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
c0d828e
to
699db96
Compare
qdm12
commented
Jan 11, 2023
jimjbrettj
reviewed
Jan 11, 2023
jimjbrettj
reviewed
Jan 11, 2023
jimjbrettj
approved these changes
Jan 11, 2023
EclesioMeloJunior
requested changes
Jan 12, 2023
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
699db96
to
fe94fd7
Compare
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
fe94fd7
to
3a4c417
Compare
EclesioMeloJunior
approved these changes
Jan 18, 2023
qdm12
force-pushed
the
qdm12/trie/tracking-struct
branch
from
3a4c417
to
364fbbe
Compare
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is done following Tim's comment #2873 (comment)
and (performance) discoveries whilst working on #2881 - this unblocks #2881Deltasstruct ininternal/trie/tracking(with unit tests)map[string]struct{}by passingpendingDeltas DeltaRecorderin the trie codeAllows for extending functionality, since it's very much needed in feat(lib/trie): cache inserted trie node Merkle values #2881Tests
go test -tags integration ./lib/trie/... ./internal/trie/tracking/...Issues
Unblocks
#2854and #2838Primary Reviewer
@timwu20