Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prom-client from 14.1.0 to 14.2.0 #5236

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Bump prom-client from 14.1.0 to 14.2.0 #5236

merged 2 commits into from
Mar 21, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Mar 6, 2023

Motivation

Update prom-client to latest version which allows to remove workaround types and also includes minor performance improvement.

Description

  • Bump prom-client from 14.1.0 to 14.2.0
  • Remove prom-client workaround types

Notable prom-client updates

@nflaig nflaig requested a review from a team as a code owner March 6, 2023 15:53
@nflaig nflaig added the meta-dependencies Pull requests that update a dependency. label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 9e18f8e Previous: 0006d86 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 591.59 us/op 977.24 us/op 0.61
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 46.357 us/op 48.576 us/op 0.95
BLS verify - blst-native 1.2529 ms/op 1.2222 ms/op 1.03
BLS verifyMultipleSignatures 3 - blst-native 2.4821 ms/op 2.5631 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.3176 ms/op 5.4137 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 19.352 ms/op 19.301 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 25.871 us/op 26.628 us/op 0.97
BLS aggregatePubkeys 128 - blst-native 100.52 us/op 102.86 us/op 0.98
getAttestationsForBlock 59.291 ms/op 55.975 ms/op 1.06
isKnown best case - 1 super set check 263.00 ns/op 277.00 ns/op 0.95
isKnown normal case - 2 super set checks 257.00 ns/op 263.00 ns/op 0.98
isKnown worse case - 16 super set checks 256.00 ns/op 261.00 ns/op 0.98
CheckpointStateCache - add get delete 5.6430 us/op 5.5290 us/op 1.02
validate gossip signedAggregateAndProof - struct 2.7960 ms/op 2.7986 ms/op 1.00
validate gossip attestation - struct 1.3405 ms/op 1.3283 ms/op 1.01
pickEth1Vote - no votes 1.3414 ms/op 1.3558 ms/op 0.99
pickEth1Vote - max votes 10.319 ms/op 9.9731 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.3118 ms/op 9.2057 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.550 ms/op 15.419 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 706.69 us/op 706.13 us/op 1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.4102 ms/op 7.0876 ms/op 0.76
bytes32 toHexString 546.00 ns/op 578.00 ns/op 0.94
bytes32 Buffer.toString(hex) 411.00 ns/op 414.00 ns/op 0.99
bytes32 Buffer.toString(hex) from Uint8Array 618.00 ns/op 641.00 ns/op 0.96
bytes32 Buffer.toString(hex) + 0x 421.00 ns/op 415.00 ns/op 1.01
Object access 1 prop 0.19700 ns/op 0.19200 ns/op 1.03
Map access 1 prop 0.17500 ns/op 0.16900 ns/op 1.04
Object get x1000 7.0220 ns/op 6.7450 ns/op 1.04
Map get x1000 0.55600 ns/op 0.66000 ns/op 0.84
Object set x1000 62.636 ns/op 71.650 ns/op 0.87
Map set x1000 52.238 ns/op 57.524 ns/op 0.91
Return object 10000 times 0.25590 ns/op 0.26850 ns/op 0.95
Throw Error 10000 times 4.4272 us/op 4.5115 us/op 0.98
fastMsgIdFn sha256 / 200 bytes 3.5580 us/op 3.5780 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 324.00 ns/op 328.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 417.00 ns/op 492.00 ns/op 0.85
fastMsgIdFn sha256 / 1000 bytes 11.901 us/op 11.973 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 458.00 ns/op 465.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 1000 bytes 509.00 ns/op 555.00 ns/op 0.92
fastMsgIdFn sha256 / 10000 bytes 102.90 us/op 105.85 us/op 0.97
fastMsgIdFn h32 xxhash / 10000 bytes 1.9740 us/op 2.0250 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.4070 us/op 1.3940 us/op 1.01
enrSubnets - fastDeserialize 64 bits 1.3650 us/op 1.7800 us/op 0.77
enrSubnets - ssz BitVector 64 bits 560.00 ns/op 608.00 ns/op 0.92
enrSubnets - fastDeserialize 4 bits 192.00 ns/op 218.00 ns/op 0.88
enrSubnets - ssz BitVector 4 bits 547.00 ns/op 631.00 ns/op 0.87
prioritizePeers score -10:0 att 32-0.1 sync 2-0 124.42 us/op 128.02 us/op 0.97
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 160.46 us/op 163.37 us/op 0.98
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 180.10 us/op 201.53 us/op 0.89
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 357.45 us/op 377.51 us/op 0.95
prioritizePeers score 0:0 att 64-1 sync 4-1 422.56 us/op 441.80 us/op 0.96
array of 16000 items push then shift 1.6665 us/op 1.6949 us/op 0.98
LinkedList of 16000 items push then shift 8.9420 ns/op 9.4130 ns/op 0.95
array of 16000 items push then pop 113.02 ns/op 117.21 ns/op 0.96
LinkedList of 16000 items push then pop 9.0440 ns/op 9.2910 ns/op 0.97
array of 24000 items push then shift 2.4083 us/op 2.4132 us/op 1.00
LinkedList of 24000 items push then shift 9.5640 ns/op 9.2620 ns/op 1.03
array of 24000 items push then pop 81.626 ns/op 87.759 ns/op 0.93
LinkedList of 24000 items push then pop 8.8390 ns/op 9.1510 ns/op 0.97
intersect bitArray bitLen 8 13.471 ns/op 13.484 ns/op 1.00
intersect array and set length 8 104.66 ns/op 87.301 ns/op 1.20
intersect bitArray bitLen 128 44.508 ns/op 45.157 ns/op 0.99
intersect array and set length 128 1.3252 us/op 1.3000 us/op 1.02
Buffer.concat 32 items 2.8010 us/op 2.7830 us/op 1.01
Uint8Array.set 32 items 2.1680 us/op 2.4930 us/op 0.87
pass gossip attestations to forkchoice per slot 2.4943 ms/op 3.7523 ms/op 0.66
computeDeltas 3.1350 ms/op 2.9915 ms/op 1.05
computeProposerBoostScoreFromBalances 1.8674 ms/op 1.7865 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei normalcase 2.6299 ms/op 2.3342 ms/op 1.13
altair processAttestation - 250000 vs - 7PWei worstcase 4.1469 ms/op 3.5442 ms/op 1.17
altair processAttestation - setStatus - 1/6 committees join 143.50 us/op 142.23 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 291.25 us/op 275.01 us/op 1.06
altair processAttestation - setStatus - 1/2 committees join 391.40 us/op 364.40 us/op 1.07
altair processAttestation - setStatus - 2/3 committees join 500.58 us/op 459.51 us/op 1.09
altair processAttestation - setStatus - 4/5 committees join 714.68 us/op 656.17 us/op 1.09
altair processAttestation - setStatus - 100% committees join 827.91 us/op 782.18 us/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase 22.364 ms/op 18.451 ms/op 1.21
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.231 ms/op 28.528 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase 59.738 ms/op 48.393 ms/op 1.23
altair processBlock - 250000 vs - 7PWei worstcase hashState 85.393 ms/op 67.603 ms/op 1.26
phase0 processBlock - 250000 vs - 7PWei normalcase 2.5678 ms/op 2.1219 ms/op 1.21
phase0 processBlock - 250000 vs - 7PWei worstcase 33.739 ms/op 29.903 ms/op 1.13
altair processEth1Data - 250000 vs - 7PWei normalcase 666.44 us/op 490.05 us/op 1.36
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 10.085 us/op 9.0500 us/op 1.11
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 33.559 us/op 28.768 us/op 1.17
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 12.772 us/op 11.078 us/op 1.15
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 11.385 us/op 8.4970 us/op 1.34
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 127.52 us/op 109.89 us/op 1.16
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 886.36 us/op 665.89 us/op 1.33
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.1720 ms/op 942.32 us/op 1.24
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 934.98 us/op 970.49 us/op 0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.6548 ms/op 2.6445 ms/op 1.00
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5658 ms/op 1.5308 ms/op 1.02
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.4912 ms/op 4.2452 ms/op 1.06
Tree 40 250000 create 425.60 ms/op 343.44 ms/op 1.24
Tree 40 250000 get(125000) 209.72 ns/op 195.21 ns/op 1.07
Tree 40 250000 set(125000) 1.2629 us/op 1.0777 us/op 1.17
Tree 40 250000 toArray() 23.546 ms/op 22.473 ms/op 1.05
Tree 40 250000 iterate all - toArray() + loop 23.327 ms/op 24.743 ms/op 0.94
Tree 40 250000 iterate all - get(i) 75.778 ms/op 74.992 ms/op 1.01
MutableVector 250000 create 10.800 ms/op 11.726 ms/op 0.92
MutableVector 250000 get(125000) 6.6830 ns/op 6.9530 ns/op 0.96
MutableVector 250000 set(125000) 267.30 ns/op 321.35 ns/op 0.83
MutableVector 250000 toArray() 3.4945 ms/op 3.6745 ms/op 0.95
MutableVector 250000 iterate all - toArray() + loop 3.5434 ms/op 3.5484 ms/op 1.00
MutableVector 250000 iterate all - get(i) 1.5772 ms/op 1.5349 ms/op 1.03
Array 250000 create 2.8882 ms/op 2.7636 ms/op 1.05
Array 250000 clone - spread 1.1623 ms/op 1.3095 ms/op 0.89
Array 250000 get(125000) 0.60900 ns/op 0.67600 ns/op 0.90
Array 250000 set(125000) 0.68900 ns/op 0.72900 ns/op 0.95
Array 250000 iterate all - loop 98.770 us/op 106.52 us/op 0.93
effectiveBalanceIncrements clone Uint8Array 300000 34.270 us/op 41.787 us/op 0.82
effectiveBalanceIncrements clone MutableVector 300000 362.00 ns/op 447.00 ns/op 0.81
effectiveBalanceIncrements rw all Uint8Array 300000 171.00 us/op 170.98 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 86.552 ms/op 100.96 ms/op 0.86
phase0 afterProcessEpoch - 250000 vs - 7PWei 120.18 ms/op 117.96 ms/op 1.02
phase0 beforeProcessEpoch - 250000 vs - 7PWei 41.232 ms/op 41.089 ms/op 1.00
altair processEpoch - mainnet_e81889 333.81 ms/op 339.58 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 63.353 ms/op 68.500 ms/op 0.92
mainnet_e81889 - altair processJustificationAndFinalization 17.153 us/op 18.170 us/op 0.94
mainnet_e81889 - altair processInactivityUpdates 5.4251 ms/op 6.1876 ms/op 0.88
mainnet_e81889 - altair processRewardsAndPenalties 70.913 ms/op 71.157 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 2.8590 us/op 4.0750 us/op 0.70
mainnet_e81889 - altair processSlashings 472.00 ns/op 554.00 ns/op 0.85
mainnet_e81889 - altair processEth1DataReset 590.00 ns/op 981.00 ns/op 0.60
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2132 ms/op 1.2539 ms/op 0.97
mainnet_e81889 - altair processSlashingsReset 3.9410 us/op 4.9190 us/op 0.80
mainnet_e81889 - altair processRandaoMixesReset 4.3420 us/op 4.3750 us/op 0.99
mainnet_e81889 - altair processHistoricalRootsUpdate 687.00 ns/op 618.00 ns/op 1.11
mainnet_e81889 - altair processParticipationFlagUpdates 2.6140 us/op 2.5290 us/op 1.03
mainnet_e81889 - altair processSyncCommitteeUpdates 858.00 ns/op 1.1520 us/op 0.74
mainnet_e81889 - altair afterProcessEpoch 125.06 ms/op 130.13 ms/op 0.96
phase0 processEpoch - mainnet_e58758 358.52 ms/op 369.78 ms/op 0.97
mainnet_e58758 - phase0 beforeProcessEpoch 133.16 ms/op 130.27 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 21.487 us/op 19.665 us/op 1.09
mainnet_e58758 - phase0 processRewardsAndPenalties 62.914 ms/op 63.483 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 9.9380 us/op 7.8840 us/op 1.26
mainnet_e58758 - phase0 processSlashings 554.00 ns/op 539.00 ns/op 1.03
mainnet_e58758 - phase0 processEth1DataReset 713.00 ns/op 514.00 ns/op 1.39
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0239 ms/op 996.57 us/op 1.03
mainnet_e58758 - phase0 processSlashingsReset 4.2670 us/op 3.4340 us/op 1.24
mainnet_e58758 - phase0 processRandaoMixesReset 3.6660 us/op 4.1750 us/op 0.88
mainnet_e58758 - phase0 processHistoricalRootsUpdate 785.00 ns/op 581.00 ns/op 1.35
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.2900 us/op 4.1920 us/op 1.02
mainnet_e58758 - phase0 afterProcessEpoch 101.69 ms/op 96.457 ms/op 1.05
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2710 ms/op 1.2226 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4435 ms/op 1.4551 ms/op 0.99
altair processInactivityUpdates - 250000 normalcase 26.653 ms/op 20.577 ms/op 1.30
altair processInactivityUpdates - 250000 worstcase 29.301 ms/op 26.158 ms/op 1.12
phase0 processRegistryUpdates - 250000 normalcase 7.6080 us/op 6.7450 us/op 1.13
phase0 processRegistryUpdates - 250000 badcase_full_deposits 312.40 us/op 235.52 us/op 1.33
phase0 processRegistryUpdates - 250000 worstcase 0.5 146.91 ms/op 127.66 ms/op 1.15
altair processRewardsAndPenalties - 250000 normalcase 74.888 ms/op 70.009 ms/op 1.07
altair processRewardsAndPenalties - 250000 worstcase 73.516 ms/op 70.226 ms/op 1.05
phase0 getAttestationDeltas - 250000 normalcase 7.1046 ms/op 6.5250 ms/op 1.09
phase0 getAttestationDeltas - 250000 worstcase 7.2395 ms/op 6.5553 ms/op 1.10
phase0 processSlashings - 250000 worstcase 4.1439 ms/op 3.3040 ms/op 1.25
altair processSyncCommitteeUpdates - 250000 187.67 ms/op 177.18 ms/op 1.06
BeaconState.hashTreeRoot - No change 342.00 ns/op 275.00 ns/op 1.24
BeaconState.hashTreeRoot - 1 full validator 54.093 us/op 58.420 us/op 0.93
BeaconState.hashTreeRoot - 32 full validator 559.57 us/op 517.82 us/op 1.08
BeaconState.hashTreeRoot - 512 full validator 5.3861 ms/op 4.9662 ms/op 1.08
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 66.006 us/op 63.203 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 932.39 us/op 877.15 us/op 1.06
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.858 ms/op 10.866 ms/op 1.09
BeaconState.hashTreeRoot - 1 balances 52.231 us/op 48.091 us/op 1.09
BeaconState.hashTreeRoot - 32 balances 488.59 us/op 480.51 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 4.3859 ms/op 4.4279 ms/op 0.99
BeaconState.hashTreeRoot - 250000 balances 73.928 ms/op 72.324 ms/op 1.02
aggregationBits - 2048 els - zipIndexesInBitList 16.952 us/op 16.452 us/op 1.03
regular array get 100000 times 39.076 us/op 40.821 us/op 0.96
wrappedArray get 100000 times 33.671 us/op 44.126 us/op 0.76
arrayWithProxy get 100000 times 16.699 ms/op 15.684 ms/op 1.06
ssz.Root.equals 578.00 ns/op 536.00 ns/op 1.08
byteArrayEquals 619.00 ns/op 535.00 ns/op 1.16
shuffle list - 16384 els 7.4606 ms/op 6.8388 ms/op 1.09
shuffle list - 250000 els 107.48 ms/op 100.83 ms/op 1.07
processSlot - 1 slots 9.8400 us/op 9.1690 us/op 1.07
processSlot - 32 slots 1.4634 ms/op 1.3175 ms/op 1.11
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 213.73 us/op 189.62 us/op 1.13
getCommitteeAssignments - req 1 vs - 250000 vc 2.9530 ms/op 2.8053 ms/op 1.05
getCommitteeAssignments - req 100 vs - 250000 vc 4.2612 ms/op 3.9907 ms/op 1.07
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5177 ms/op 4.3849 ms/op 1.03
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.4400 ns/op 4.7500 ns/op 1.15
state getBlockRootAtSlot - 250000 vs - 7PWei 729.52 ns/op 937.51 ns/op 0.78
computeProposers - vc 250000 12.708 ms/op 10.233 ms/op 1.24
computeEpochShuffling - vc 250000 107.87 ms/op 102.70 ms/op 1.05
getNextSyncCommittee - vc 250000 184.87 ms/op 174.76 ms/op 1.06

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 9b20c54 into unstable Mar 21, 2023
@wemeetagain wemeetagain deleted the nflaig/update-prom-client branch March 21, 2023 15:55
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
meta-dependencies Pull requests that update a dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain