fix: add get method to type definitions of metric classes #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Limitation
At the moment there is no clean way to get a single metric value programmatically while using typescript.
The following is not possible as it causes type issues as the getters are implemented in javascript but are missing from type definitions.
Solution
Add
get
method to type definitions of each metric classes and defineMetricObjectWithValues
type which is returned by getters.