Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unschedule capella in chiado and gnosis #5324

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Unschedule capella in chiado and gnosis #5324

merged 1 commit into from
Mar 30, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Mar 30, 2023

Because of mainnet scheduling of Capella a bug was introduced in chiado and gnosis configs where which inherits configs from mainnet

This PR explicitly unschedules capella iin them

@g11tech g11tech requested a review from a team as a code owner March 30, 2023 15:20
@g11tech g11tech enabled auto-merge (squash) March 30, 2023 15:20
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: d7095d0 Previous: 7e34b46 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 634.82 us/op 788.50 us/op 0.81
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 61.840 us/op 52.994 us/op 1.17
BLS verify - blst-native 1.3301 ms/op 1.2878 ms/op 1.03
BLS verifyMultipleSignatures 3 - blst-native 2.5689 ms/op 2.8222 ms/op 0.91
BLS verifyMultipleSignatures 8 - blst-native 5.6644 ms/op 5.7911 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 20.253 ms/op 22.988 ms/op 0.88
BLS aggregatePubkeys 32 - blst-native 27.225 us/op 28.539 us/op 0.95
BLS aggregatePubkeys 128 - blst-native 105.32 us/op 108.81 us/op 0.97
getAttestationsForBlock 72.696 ms/op 70.587 ms/op 1.03
isKnown best case - 1 super set check 275.00 ns/op 278.00 ns/op 0.99
isKnown normal case - 2 super set checks 265.00 ns/op 260.00 ns/op 1.02
isKnown worse case - 16 super set checks 266.00 ns/op 260.00 ns/op 1.02
CheckpointStateCache - add get delete 5.8420 us/op 6.3990 us/op 0.91
validate gossip signedAggregateAndProof - struct 2.9038 ms/op 2.8720 ms/op 1.01
validate gossip attestation - struct 1.3859 ms/op 1.3676 ms/op 1.01
pickEth1Vote - no votes 1.3640 ms/op 1.4140 ms/op 0.96
pickEth1Vote - max votes 12.889 ms/op 10.961 ms/op 1.18
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.095 ms/op 9.7948 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 17.705 ms/op 15.480 ms/op 1.14
pickEth1Vote - Eth1Data fastSerialize value x2048 782.71 us/op 717.98 us/op 1.09
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.4810 ms/op 5.3897 ms/op 1.39
bytes32 toHexString 714.00 ns/op 552.00 ns/op 1.29
bytes32 Buffer.toString(hex) 443.00 ns/op 416.00 ns/op 1.06
bytes32 Buffer.toString(hex) from Uint8Array 667.00 ns/op 624.00 ns/op 1.07
bytes32 Buffer.toString(hex) + 0x 419.00 ns/op 415.00 ns/op 1.01
Object access 1 prop 0.19800 ns/op 0.19000 ns/op 1.04
Map access 1 prop 0.17300 ns/op 0.16800 ns/op 1.03
Object get x1000 6.8610 ns/op 6.9540 ns/op 0.99
Map get x1000 0.61700 ns/op 0.68200 ns/op 0.90
Object set x1000 71.519 ns/op 62.163 ns/op 1.15
Map set x1000 56.630 ns/op 49.036 ns/op 1.15
Return object 10000 times 0.24880 ns/op 0.24960 ns/op 1.00
Throw Error 10000 times 4.4770 us/op 4.3166 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.6190 us/op 3.5610 us/op 1.02
fastMsgIdFn h32 xxhash / 200 bytes 322.00 ns/op 316.00 ns/op 1.02
fastMsgIdFn h64 xxhash / 200 bytes 470.00 ns/op 477.00 ns/op 0.99
fastMsgIdFn sha256 / 1000 bytes 12.612 us/op 12.128 us/op 1.04
fastMsgIdFn h32 xxhash / 1000 bytes 497.00 ns/op 458.00 ns/op 1.09
fastMsgIdFn h64 xxhash / 1000 bytes 593.00 ns/op 586.00 ns/op 1.01
fastMsgIdFn sha256 / 10000 bytes 107.55 us/op 107.50 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.0660 us/op 2.0420 us/op 1.01
fastMsgIdFn h64 xxhash / 10000 bytes 1.5390 us/op 1.5070 us/op 1.02
enrSubnets - fastDeserialize 64 bits 1.7150 us/op 1.6140 us/op 1.06
enrSubnets - ssz BitVector 64 bits 608.00 ns/op 619.00 ns/op 0.98
enrSubnets - fastDeserialize 4 bits 209.00 ns/op 209.00 ns/op 1.00
enrSubnets - ssz BitVector 4 bits 678.00 ns/op 649.00 ns/op 1.04
prioritizePeers score -10:0 att 32-0.1 sync 2-0 127.09 us/op 118.05 us/op 1.08
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 160.82 us/op 169.20 us/op 0.95
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 202.48 us/op 201.38 us/op 1.01
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 369.50 us/op 397.45 us/op 0.93
prioritizePeers score 0:0 att 64-1 sync 4-1 437.63 us/op 450.47 us/op 0.97
array of 16000 items push then shift 1.7776 us/op 1.9690 us/op 0.90
LinkedList of 16000 items push then shift 10.222 ns/op 11.304 ns/op 0.90
array of 16000 items push then pop 123.83 ns/op 128.26 ns/op 0.97
LinkedList of 16000 items push then pop 9.4170 ns/op 9.6870 ns/op 0.97
array of 24000 items push then shift 2.5049 us/op 2.5443 us/op 0.98
LinkedList of 24000 items push then shift 9.9110 ns/op 9.9610 ns/op 0.99
array of 24000 items push then pop 94.381 ns/op 90.048 ns/op 1.05
LinkedList of 24000 items push then pop 9.2580 ns/op 11.252 ns/op 0.82
intersect bitArray bitLen 8 14.128 ns/op 16.766 ns/op 0.84
intersect array and set length 8 103.98 ns/op 97.429 ns/op 1.07
intersect bitArray bitLen 128 47.485 ns/op 54.104 ns/op 0.88
intersect array and set length 128 1.3373 us/op 1.4473 us/op 0.92
Buffer.concat 32 items 3.2070 us/op 3.7920 us/op 0.85
Uint8Array.set 32 items 2.4970 us/op 3.9580 us/op 0.63
pass gossip attestations to forkchoice per slot 3.7607 ms/op 4.3826 ms/op 0.86
computeDeltas 3.2819 ms/op 3.8631 ms/op 0.85
computeProposerBoostScoreFromBalances 1.8310 ms/op 1.8560 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei normalcase 3.1292 ms/op 3.2105 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei worstcase 4.3826 ms/op 4.5978 ms/op 0.95
altair processAttestation - setStatus - 1/6 committees join 145.08 us/op 147.14 us/op 0.99
altair processAttestation - setStatus - 1/3 committees join 280.99 us/op 301.19 us/op 0.93
altair processAttestation - setStatus - 1/2 committees join 386.91 us/op 393.94 us/op 0.98
altair processAttestation - setStatus - 2/3 committees join 469.13 us/op 491.17 us/op 0.96
altair processAttestation - setStatus - 4/5 committees join 669.32 us/op 769.67 us/op 0.87
altair processAttestation - setStatus - 100% committees join 790.11 us/op 831.51 us/op 0.95
altair processBlock - 250000 vs - 7PWei normalcase 16.959 ms/op 17.295 ms/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.238 ms/op 29.404 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase 49.225 ms/op 50.710 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase hashState 76.695 ms/op 72.084 ms/op 1.06
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3848 ms/op 2.4795 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei worstcase 32.514 ms/op 31.343 ms/op 1.04
altair processEth1Data - 250000 vs - 7PWei normalcase 610.40 us/op 484.28 us/op 1.26
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 11.096 us/op 8.1590 us/op 1.36
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 30.245 us/op 27.567 us/op 1.10
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 14.635 us/op 12.601 us/op 1.16
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 13.823 us/op 8.4920 us/op 1.63
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 130.18 us/op 96.091 us/op 1.35
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 682.00 us/op 660.68 us/op 1.03
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 916.29 us/op 904.62 us/op 1.01
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 977.41 us/op 903.18 us/op 1.08
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.4969 ms/op 2.4826 ms/op 1.01
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.6101 ms/op 1.6234 ms/op 0.99
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.3092 ms/op 3.9125 ms/op 1.10
Tree 40 250000 create 370.21 ms/op 332.67 ms/op 1.11
Tree 40 250000 get(125000) 199.62 ns/op 198.90 ns/op 1.00
Tree 40 250000 set(125000) 1.1097 us/op 1.1753 us/op 0.94
Tree 40 250000 toArray() 22.086 ms/op 23.199 ms/op 0.95
Tree 40 250000 iterate all - toArray() + loop 22.373 ms/op 23.235 ms/op 0.96
Tree 40 250000 iterate all - get(i) 79.909 ms/op 75.813 ms/op 1.05
MutableVector 250000 create 11.814 ms/op 11.163 ms/op 1.06
MutableVector 250000 get(125000) 6.4790 ns/op 6.8400 ns/op 0.95
MutableVector 250000 set(125000) 294.38 ns/op 570.28 ns/op 0.52
MutableVector 250000 toArray() 3.7701 ms/op 5.0194 ms/op 0.75
MutableVector 250000 iterate all - toArray() + loop 3.9139 ms/op 4.0309 ms/op 0.97
MutableVector 250000 iterate all - get(i) 1.5752 ms/op 1.8576 ms/op 0.85
Array 250000 create 3.0953 ms/op 3.9881 ms/op 0.78
Array 250000 clone - spread 1.2587 ms/op 1.3513 ms/op 0.93
Array 250000 get(125000) 0.66900 ns/op 0.84900 ns/op 0.79
Array 250000 set(125000) 0.71200 ns/op 0.90400 ns/op 0.79
Array 250000 iterate all - loop 104.32 us/op 100.41 us/op 1.04
effectiveBalanceIncrements clone Uint8Array 300000 46.434 us/op 50.789 us/op 0.91
effectiveBalanceIncrements clone MutableVector 300000 389.00 ns/op 378.00 ns/op 1.03
effectiveBalanceIncrements rw all Uint8Array 300000 172.18 us/op 232.56 us/op 0.74
effectiveBalanceIncrements rw all MutableVector 300000 109.60 ms/op 128.27 ms/op 0.85
phase0 afterProcessEpoch - 250000 vs - 7PWei 121.28 ms/op 141.07 ms/op 0.86
phase0 beforeProcessEpoch - 250000 vs - 7PWei 47.429 ms/op 61.439 ms/op 0.77
altair processEpoch - mainnet_e81889 439.50 ms/op 435.80 ms/op 1.01
mainnet_e81889 - altair beforeProcessEpoch 113.34 ms/op 99.648 ms/op 1.14
mainnet_e81889 - altair processJustificationAndFinalization 36.162 us/op 38.161 us/op 0.95
mainnet_e81889 - altair processInactivityUpdates 8.4213 ms/op 9.2342 ms/op 0.91
mainnet_e81889 - altair processRewardsAndPenalties 62.271 ms/op 92.103 ms/op 0.68
mainnet_e81889 - altair processRegistryUpdates 8.5240 us/op 8.9540 us/op 0.95
mainnet_e81889 - altair processSlashings 1.6610 us/op 1.1140 us/op 1.49
mainnet_e81889 - altair processEth1DataReset 1.2130 us/op 1.9340 us/op 0.63
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3644 ms/op 2.1355 ms/op 0.64
mainnet_e81889 - altair processSlashingsReset 7.4150 us/op 19.235 us/op 0.39
mainnet_e81889 - altair processRandaoMixesReset 11.053 us/op 10.682 us/op 1.03
mainnet_e81889 - altair processHistoricalRootsUpdate 2.0320 us/op 2.2750 us/op 0.89
mainnet_e81889 - altair processParticipationFlagUpdates 5.9250 us/op 6.7940 us/op 0.87
mainnet_e81889 - altair processSyncCommitteeUpdates 2.2260 us/op 1.8850 us/op 1.18
mainnet_e81889 - altair afterProcessEpoch 154.00 ms/op 150.97 ms/op 1.02
phase0 processEpoch - mainnet_e58758 529.41 ms/op 518.06 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 224.16 ms/op 211.89 ms/op 1.06
mainnet_e58758 - phase0 processJustificationAndFinalization 42.532 us/op 31.876 us/op 1.33
mainnet_e58758 - phase0 processRewardsAndPenalties 91.994 ms/op 78.160 ms/op 1.18
mainnet_e58758 - phase0 processRegistryUpdates 19.083 us/op 19.527 us/op 0.98
mainnet_e58758 - phase0 processSlashings 1.5510 us/op 1.4580 us/op 1.06
mainnet_e58758 - phase0 processEth1DataReset 1.5700 us/op 970.00 ns/op 1.62
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 4.9379 ms/op 2.0152 ms/op 2.45
mainnet_e58758 - phase0 processSlashingsReset 10.464 us/op 6.0040 us/op 1.74
mainnet_e58758 - phase0 processRandaoMixesReset 13.218 us/op 11.673 us/op 1.13
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.8200 us/op 1.3000 us/op 1.40
mainnet_e58758 - phase0 processParticipationRecordUpdates 8.8770 us/op 12.275 us/op 0.72
mainnet_e58758 - phase0 afterProcessEpoch 107.56 ms/op 111.05 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3968 ms/op 1.5586 ms/op 0.90
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6102 ms/op 2.4281 ms/op 0.66
altair processInactivityUpdates - 250000 normalcase 34.439 ms/op 29.005 ms/op 1.19
altair processInactivityUpdates - 250000 worstcase 32.591 ms/op 28.136 ms/op 1.16
phase0 processRegistryUpdates - 250000 normalcase 16.819 us/op 12.475 us/op 1.35
phase0 processRegistryUpdates - 250000 badcase_full_deposits 341.63 us/op 311.75 us/op 1.10
phase0 processRegistryUpdates - 250000 worstcase 0.5 172.60 ms/op 135.35 ms/op 1.28
altair processRewardsAndPenalties - 250000 normalcase 78.429 ms/op 70.749 ms/op 1.11
altair processRewardsAndPenalties - 250000 worstcase 76.142 ms/op 71.314 ms/op 1.07
phase0 getAttestationDeltas - 250000 normalcase 8.2973 ms/op 6.7947 ms/op 1.22
phase0 getAttestationDeltas - 250000 worstcase 7.1692 ms/op 6.7542 ms/op 1.06
phase0 processSlashings - 250000 worstcase 3.7419 ms/op 3.3899 ms/op 1.10
altair processSyncCommitteeUpdates - 250000 196.80 ms/op 177.77 ms/op 1.11
BeaconState.hashTreeRoot - No change 312.00 ns/op 265.00 ns/op 1.18
BeaconState.hashTreeRoot - 1 full validator 58.261 us/op 52.823 us/op 1.10
BeaconState.hashTreeRoot - 32 full validator 744.52 us/op 488.56 us/op 1.52
BeaconState.hashTreeRoot - 512 full validator 8.3563 ms/op 5.9450 ms/op 1.41
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 71.420 us/op 63.184 us/op 1.13
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0360 ms/op 919.49 us/op 1.13
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.412 ms/op 11.812 ms/op 1.14
BeaconState.hashTreeRoot - 1 balances 52.349 us/op 47.361 us/op 1.11
BeaconState.hashTreeRoot - 32 balances 472.69 us/op 459.32 us/op 1.03
BeaconState.hashTreeRoot - 512 balances 5.0803 ms/op 4.4027 ms/op 1.15
BeaconState.hashTreeRoot - 250000 balances 80.079 ms/op 75.560 ms/op 1.06
aggregationBits - 2048 els - zipIndexesInBitList 20.679 us/op 16.779 us/op 1.23
regular array get 100000 times 48.991 us/op 33.246 us/op 1.47
wrappedArray get 100000 times 42.918 us/op 33.435 us/op 1.28
arrayWithProxy get 100000 times 17.290 ms/op 15.814 ms/op 1.09
ssz.Root.equals 602.00 ns/op 562.00 ns/op 1.07
byteArrayEquals 587.00 ns/op 567.00 ns/op 1.04
shuffle list - 16384 els 7.3354 ms/op 7.0083 ms/op 1.05
shuffle list - 250000 els 108.35 ms/op 102.71 ms/op 1.05
processSlot - 1 slots 10.009 us/op 9.2680 us/op 1.08
processSlot - 32 slots 1.4863 ms/op 1.3462 ms/op 1.10
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 40.145 ms/op 37.205 ms/op 1.08
getCommitteeAssignments - req 1 vs - 250000 vc 3.3037 ms/op 2.8053 ms/op 1.18
getCommitteeAssignments - req 100 vs - 250000 vc 4.6374 ms/op 3.9988 ms/op 1.16
getCommitteeAssignments - req 1000 vs - 250000 vc 4.9006 ms/op 4.3625 ms/op 1.12
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.9100 ns/op 4.5000 ns/op 1.31
state getBlockRootAtSlot - 250000 vs - 7PWei 794.08 ns/op 898.71 ns/op 0.88
computeProposers - vc 250000 13.148 ms/op 10.115 ms/op 1.30
computeEpochShuffling - vc 250000 115.54 ms/op 102.77 ms/op 1.12
getNextSyncCommittee - vc 250000 205.55 ms/op 170.63 ms/op 1.20

by benchmarkbot/action

@g11tech g11tech merged commit a2f749a into unstable Mar 30, 2023
@g11tech g11tech deleted the g11tech/fix-chiado-gnosis-capella branch March 30, 2023 16:05
@nflaig nflaig mentioned this pull request Mar 30, 2023
Closed
philknows pushed a commit that referenced this pull request Mar 30, 2023
@g11tech @philknows
Unschedule capella in chiado and gnosis (#5324)
c266c51
@philknows philknows mentioned this pull request Mar 30, 2023
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.7.2 🎉

@dapplion
Copy link
Contributor

Yeah I noticed the risk of scheduling forks accidentally due to how they are inherit. I think we should have some more definitive solution to prevent this from happening again

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.8.0 🎉

@nflaig nflaig mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g11tech @wemeetagain @dapplion @nflaig