Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.7.2 Release #5326

Merged
merged 2 commits into from
Mar 30, 2023
Merged

v1.7.2 Release #5326

merged 2 commits into from
Mar 30, 2023

Conversation

philknows
Copy link
Member

Motivation

Adds #5324 for Gnosis/Chiado network users

Description

Fixes breaking issue.

@philknows philknows requested a review from a team as a code owner March 30, 2023 18:08
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 15d1706 Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 937.76 us/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 53.631 us/op
BLS verify - blst-native 1.2482 ms/op
BLS verifyMultipleSignatures 3 - blst-native 2.5278 ms/op
BLS verifyMultipleSignatures 8 - blst-native 5.5073 ms/op
BLS verifyMultipleSignatures 32 - blst-native 20.067 ms/op
BLS aggregatePubkeys 32 - blst-native 27.178 us/op
BLS aggregatePubkeys 128 - blst-native 104.78 us/op
getAttestationsForBlock 62.758 ms/op
isKnown best case - 1 super set check 270.00 ns/op
isKnown normal case - 2 super set checks 263.00 ns/op
isKnown worse case - 16 super set checks 254.00 ns/op
CheckpointStateCache - add get delete 5.8600 us/op
validate gossip signedAggregateAndProof - struct 2.8735 ms/op
validate gossip attestation - struct 1.3655 ms/op
pickEth1Vote - no votes 1.3825 ms/op
pickEth1Vote - max votes 12.395 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.6706 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.878 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 773.75 us/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.3539 ms/op
bytes32 toHexString 679.00 ns/op
bytes32 Buffer.toString(hex) 443.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 642.00 ns/op
bytes32 Buffer.toString(hex) + 0x 439.00 ns/op
Object access 1 prop 0.20700 ns/op
Map access 1 prop 0.17100 ns/op
Object get x1000 7.0900 ns/op
Map get x1000 0.69600 ns/op
Object set x1000 70.341 ns/op
Map set x1000 56.484 ns/op
Return object 10000 times 0.25110 ns/op
Throw Error 10000 times 4.3641 us/op
fastMsgIdFn sha256 / 200 bytes 3.5970 us/op
fastMsgIdFn h32 xxhash / 200 bytes 318.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 472.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 11.976 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 447.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 558.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 107.00 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 2.0360 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.4880 us/op
enrSubnets - fastDeserialize 64 bits 1.6790 us/op
enrSubnets - ssz BitVector 64 bits 603.00 ns/op
enrSubnets - fastDeserialize 4 bits 209.00 ns/op
enrSubnets - ssz BitVector 4 bits 595.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 122.57 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 158.12 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 197.52 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 379.35 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 449.74 us/op
array of 16000 items push then shift 1.6997 us/op
LinkedList of 16000 items push then shift 9.3280 ns/op
array of 16000 items push then pop 120.46 ns/op
LinkedList of 16000 items push then pop 9.2990 ns/op
array of 24000 items push then shift 2.3982 us/op
LinkedList of 24000 items push then shift 9.8580 ns/op
array of 24000 items push then pop 92.555 ns/op
LinkedList of 24000 items push then pop 9.9240 ns/op
intersect bitArray bitLen 8 14.302 ns/op
intersect array and set length 8 104.74 ns/op
intersect bitArray bitLen 128 46.252 ns/op
intersect array and set length 128 1.3099 us/op
Buffer.concat 32 items 3.2930 us/op
Uint8Array.set 32 items 2.4780 us/op
pass gossip attestations to forkchoice per slot 3.0380 ms/op
computeDeltas 3.5215 ms/op
computeProposerBoostScoreFromBalances 1.8493 ms/op
altair processAttestation - 250000 vs - 7PWei normalcase 2.9422 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 4.9179 ms/op
altair processAttestation - setStatus - 1/6 committees join 155.97 us/op
altair processAttestation - setStatus - 1/3 committees join 289.72 us/op
altair processAttestation - setStatus - 1/2 committees join 400.79 us/op
altair processAttestation - setStatus - 2/3 committees join 485.51 us/op
altair processAttestation - setStatus - 4/5 committees join 708.66 us/op
altair processAttestation - setStatus - 100% committees join 788.29 us/op
altair processBlock - 250000 vs - 7PWei normalcase 22.362 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 31.204 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 58.614 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 79.815 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8837 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 33.504 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 834.51 us/op
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 12.911 us/op
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 35.952 us/op
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 17.374 us/op
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 13.233 us/op
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 133.74 us/op
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 873.92 us/op
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 927.36 us/op
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.0074 ms/op
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 3.5936 ms/op
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 2.1297 ms/op
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 7.7461 ms/op
Tree 40 250000 create 802.11 ms/op
Tree 40 250000 get(125000) 222.94 ns/op
Tree 40 250000 set(125000) 2.3025 us/op
Tree 40 250000 toArray() 33.008 ms/op
Tree 40 250000 iterate all - toArray() + loop 31.580 ms/op
Tree 40 250000 iterate all - get(i) 99.313 ms/op
MutableVector 250000 create 15.917 ms/op
MutableVector 250000 get(125000) 7.1790 ns/op
MutableVector 250000 set(125000) 817.80 ns/op
MutableVector 250000 toArray() 6.9434 ms/op
MutableVector 250000 iterate all - toArray() + loop 5.8807 ms/op
MutableVector 250000 iterate all - get(i) 1.9759 ms/op
Array 250000 create 4.3534 ms/op
Array 250000 clone - spread 2.4561 ms/op
Array 250000 get(125000) 1.5640 ns/op
Array 250000 set(125000) 1.6980 ns/op
Array 250000 iterate all - loop 90.781 us/op
effectiveBalanceIncrements clone Uint8Array 300000 76.824 us/op
effectiveBalanceIncrements clone MutableVector 300000 629.00 ns/op
effectiveBalanceIncrements rw all Uint8Array 300000 191.28 us/op
effectiveBalanceIncrements rw all MutableVector 300000 163.36 ms/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 130.85 ms/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 66.911 ms/op
altair processEpoch - mainnet_e81889 372.35 ms/op
mainnet_e81889 - altair beforeProcessEpoch 62.651 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 18.823 us/op
mainnet_e81889 - altair processInactivityUpdates 7.7933 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 71.365 ms/op
mainnet_e81889 - altair processRegistryUpdates 3.2040 us/op
mainnet_e81889 - altair processSlashings 849.00 ns/op
mainnet_e81889 - altair processEth1DataReset 684.00 ns/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.1195 ms/op
mainnet_e81889 - altair processSlashingsReset 11.564 us/op
mainnet_e81889 - altair processRandaoMixesReset 12.834 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2790 us/op
mainnet_e81889 - altair processParticipationFlagUpdates 4.1290 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 999.00 ns/op
mainnet_e81889 - altair afterProcessEpoch 137.10 ms/op
phase0 processEpoch - mainnet_e58758 474.91 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 209.84 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 31.552 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 78.807 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 18.762 us/op
mainnet_e58758 - phase0 processSlashings 1.4290 us/op
mainnet_e58758 - phase0 processEth1DataReset 960.00 ns/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1199 ms/op
mainnet_e58758 - phase0 processSlashingsReset 5.6630 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 7.6360 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.1160 us/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.3830 us/op
mainnet_e58758 - phase0 afterProcessEpoch 104.20 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2614 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6919 ms/op
altair processInactivityUpdates - 250000 normalcase 26.151 ms/op
altair processInactivityUpdates - 250000 worstcase 30.880 ms/op
phase0 processRegistryUpdates - 250000 normalcase 9.3240 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 351.56 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 155.49 ms/op
altair processRewardsAndPenalties - 250000 normalcase 79.835 ms/op
altair processRewardsAndPenalties - 250000 worstcase 78.117 ms/op
phase0 getAttestationDeltas - 250000 normalcase 8.9307 ms/op
phase0 getAttestationDeltas - 250000 worstcase 8.3190 ms/op
phase0 processSlashings - 250000 worstcase 3.5962 ms/op
altair processSyncCommitteeUpdates - 250000 190.23 ms/op
BeaconState.hashTreeRoot - No change 310.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 55.638 us/op
BeaconState.hashTreeRoot - 32 full validator 537.46 us/op
BeaconState.hashTreeRoot - 512 full validator 6.5385 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 70.187 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 991.98 us/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.420 ms/op
BeaconState.hashTreeRoot - 1 balances 51.410 us/op
BeaconState.hashTreeRoot - 32 balances 486.47 us/op
BeaconState.hashTreeRoot - 512 balances 5.6324 ms/op
BeaconState.hashTreeRoot - 250000 balances 81.737 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 21.827 us/op
regular array get 100000 times 34.488 us/op
wrappedArray get 100000 times 45.339 us/op
arrayWithProxy get 100000 times 16.046 ms/op
ssz.Root.equals 576.00 ns/op
byteArrayEquals 571.00 ns/op
shuffle list - 16384 els 7.0764 ms/op
shuffle list - 250000 els 104.31 ms/op
processSlot - 1 slots 11.627 us/op
processSlot - 32 slots 1.4449 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 45.059 ms/op
getCommitteeAssignments - req 1 vs - 250000 vc 3.0136 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 4.3232 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6482 ms/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.8400 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 928.13 ns/op
computeProposers - vc 250000 11.722 ms/op
computeEpochShuffling - vc 250000 107.41 ms/op
getNextSyncCommittee - vc 250000 196.31 ms/op

by benchmarkbot/action

@philknows philknows merged commit 2a727af into stable Mar 30, 2023
@philknows philknows deleted the rc/v1.7.2 branch March 30, 2023 18:36
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.7.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philknows @wemeetagain @g11tech