Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow release from stable in release process #5367

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Allow release from stable in release process #5367

merged 3 commits into from
Apr 15, 2023

Conversation

wemeetagain
Copy link
Member

Motivation

1.8.0 needs to be released before our unstable branch can be stablized.
Our release process doc should be updated to reflect the occasional need to release a non-patch release from stable.

@wemeetagain wemeetagain requested a review from a team as a code owner April 15, 2023 18:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 28f61ca Previous: fb90b02 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 839.90 us/op 732.24 us/op 1.15
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 44.459 us/op 45.914 us/op 0.97
BLS verify - blst-native 1.1962 ms/op 1.2082 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.4262 ms/op 2.4536 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.2125 ms/op 5.2699 ms/op 0.99
BLS verifyMultipleSignatures 32 - blst-native 18.832 ms/op 19.057 ms/op 0.99
BLS aggregatePubkeys 32 - blst-native 25.223 us/op 25.453 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 98.729 us/op 99.864 us/op 0.99
getAttestationsForBlock 54.117 ms/op 50.283 ms/op 1.08
isKnown best case - 1 super set check 257.00 ns/op 256.00 ns/op 1.00
isKnown normal case - 2 super set checks 255.00 ns/op 247.00 ns/op 1.03
isKnown worse case - 16 super set checks 253.00 ns/op 245.00 ns/op 1.03
CheckpointStateCache - add get delete 4.7880 us/op 4.8100 us/op 1.00
validate gossip signedAggregateAndProof - struct 2.7222 ms/op 2.7061 ms/op 1.01
validate gossip attestation - struct 1.3053 ms/op 1.2917 ms/op 1.01
pickEth1Vote - no votes 1.2649 ms/op 1.1988 ms/op 1.06
pickEth1Vote - max votes 10.724 ms/op 10.881 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.6560 ms/op 8.8327 ms/op 0.98
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.435 ms/op 13.300 ms/op 1.09
pickEth1Vote - Eth1Data fastSerialize value x2048 652.62 us/op 627.50 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.8896 ms/op 7.8009 ms/op 1.01
bytes32 toHexString 476.00 ns/op 486.00 ns/op 0.98
bytes32 Buffer.toString(hex) 340.00 ns/op 346.00 ns/op 0.98
bytes32 Buffer.toString(hex) from Uint8Array 534.00 ns/op 549.00 ns/op 0.97
bytes32 Buffer.toString(hex) + 0x 337.00 ns/op 347.00 ns/op 0.97
Object access 1 prop 0.15700 ns/op 0.17400 ns/op 0.90
Map access 1 prop 0.15100 ns/op 0.16500 ns/op 0.92
Object get x1000 6.4320 ns/op 6.5140 ns/op 0.99
Map get x1000 0.60500 ns/op 0.61400 ns/op 0.99
Object set x1000 50.909 ns/op 51.454 ns/op 0.99
Map set x1000 42.783 ns/op 42.054 ns/op 1.02
Return object 10000 times 0.23070 ns/op 0.23490 ns/op 0.98
Throw Error 10000 times 4.1234 us/op 4.0815 us/op 1.01
fastMsgIdFn sha256 / 200 bytes 3.3560 us/op 3.4010 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 273.00 ns/op 276.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 367.00 ns/op 389.00 ns/op 0.94
fastMsgIdFn sha256 / 1000 bytes 11.412 us/op 11.493 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 402.00 ns/op 403.00 ns/op 1.00
fastMsgIdFn h64 xxhash / 1000 bytes 442.00 ns/op 466.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 101.84 us/op 103.29 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.8670 us/op 1.8780 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.3270 us/op 1.3190 us/op 1.01
enrSubnets - fastDeserialize 64 bits 1.2380 us/op 1.2710 us/op 0.97
enrSubnets - ssz BitVector 64 bits 464.00 ns/op 494.00 ns/op 0.94
enrSubnets - fastDeserialize 4 bits 162.00 ns/op 174.00 ns/op 0.93
enrSubnets - ssz BitVector 4 bits 456.00 ns/op 495.00 ns/op 0.92
prioritizePeers score -10:0 att 32-0.1 sync 2-0 101.65 us/op 103.29 us/op 0.98
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 129.87 us/op 132.40 us/op 0.98
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 162.61 us/op 168.41 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 295.17 us/op 296.82 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 366.69 us/op 358.50 us/op 1.02
array of 16000 items push then shift 1.5982 us/op 1.5521 us/op 1.03
LinkedList of 16000 items push then shift 8.7590 ns/op 8.4330 ns/op 1.04
array of 16000 items push then pop 78.821 ns/op 78.012 ns/op 1.01
LinkedList of 16000 items push then pop 8.4410 ns/op 8.5470 ns/op 0.99
array of 24000 items push then shift 2.3030 us/op 2.3428 us/op 0.98
LinkedList of 24000 items push then shift 8.6130 ns/op 8.7590 ns/op 0.98
array of 24000 items push then pop 77.272 ns/op 74.784 ns/op 1.03
LinkedList of 24000 items push then pop 8.2730 ns/op 8.4640 ns/op 0.98
intersect bitArray bitLen 8 13.027 ns/op 13.232 ns/op 0.98
intersect array and set length 8 76.031 ns/op 76.794 ns/op 0.99
intersect bitArray bitLen 128 43.261 ns/op 44.064 ns/op 0.98
intersect array and set length 128 1.0298 us/op 1.0415 us/op 0.99
Buffer.concat 32 items 2.8630 us/op 2.8380 us/op 1.01
Uint8Array.set 32 items 2.8900 us/op 2.5370 us/op 1.14
pass gossip attestations to forkchoice per slot 2.5465 ms/op 2.7854 ms/op 0.91
computeDeltas 2.8528 ms/op 3.3318 ms/op 0.86
computeProposerBoostScoreFromBalances 1.7658 ms/op 2.0134 ms/op 0.88
altair processAttestation - 250000 vs - 7PWei normalcase 2.1208 ms/op 2.1588 ms/op 0.98
altair processAttestation - 250000 vs - 7PWei worstcase 3.2425 ms/op 3.2925 ms/op 0.98
altair processAttestation - setStatus - 1/6 committees join 138.60 us/op 136.76 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 265.61 us/op 269.73 us/op 0.98
altair processAttestation - setStatus - 1/2 committees join 361.14 us/op 359.98 us/op 1.00
altair processAttestation - setStatus - 2/3 committees join 478.20 us/op 453.74 us/op 1.05
altair processAttestation - setStatus - 4/5 committees join 644.55 us/op 604.61 us/op 1.07
altair processAttestation - setStatus - 100% committees join 763.80 us/op 737.90 us/op 1.04
altair processBlock - 250000 vs - 7PWei normalcase 18.324 ms/op 16.059 ms/op 1.14
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.591 ms/op 27.864 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 49.744 ms/op 51.682 ms/op 0.96
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.262 ms/op 66.315 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9772 ms/op 2.0132 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei worstcase 27.738 ms/op 28.131 ms/op 0.99
altair processEth1Data - 250000 vs - 7PWei normalcase 512.36 us/op 504.26 us/op 1.02
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 6.8810 us/op 6.7770 us/op 1.02
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 19.281 us/op 20.399 us/op 0.95
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.1620 us/op 8.3390 us/op 0.98
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.2440 us/op 6.4630 us/op 0.97
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 73.750 us/op 74.579 us/op 0.99
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 614.07 us/op 595.95 us/op 1.03
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 905.51 us/op 898.16 us/op 1.01
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 874.04 us/op 870.51 us/op 1.00
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.2283 ms/op 2.4374 ms/op 0.91
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5634 ms/op 1.5915 ms/op 0.98
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.7544 ms/op 3.6042 ms/op 1.04
Tree 40 250000 create 298.40 ms/op 314.02 ms/op 0.95
Tree 40 250000 get(125000) 176.59 ns/op 171.16 ns/op 1.03
Tree 40 250000 set(125000) 886.52 ns/op 892.04 ns/op 0.99
Tree 40 250000 toArray() 16.883 ms/op 16.446 ms/op 1.03
Tree 40 250000 iterate all - toArray() + loop 17.032 ms/op 16.367 ms/op 1.04
Tree 40 250000 iterate all - get(i) 65.299 ms/op 63.443 ms/op 1.03
MutableVector 250000 create 10.821 ms/op 9.2576 ms/op 1.17
MutableVector 250000 get(125000) 6.1380 ns/op 6.3170 ns/op 0.97
MutableVector 250000 set(125000) 249.50 ns/op 245.50 ns/op 1.02
MutableVector 250000 toArray() 2.7218 ms/op 2.7291 ms/op 1.00
MutableVector 250000 iterate all - toArray() + loop 2.8067 ms/op 2.8111 ms/op 1.00
MutableVector 250000 iterate all - get(i) 1.5163 ms/op 1.5140 ms/op 1.00
Array 250000 create 2.5478 ms/op 2.4898 ms/op 1.02
Array 250000 clone - spread 1.2489 ms/op 1.1160 ms/op 1.12
Array 250000 get(125000) 0.59800 ns/op 0.54700 ns/op 1.09
Array 250000 set(125000) 0.68500 ns/op 0.63100 ns/op 1.09
Array 250000 iterate all - loop 81.938 us/op 107.27 us/op 0.76
effectiveBalanceIncrements clone Uint8Array 300000 26.840 us/op 23.616 us/op 1.14
effectiveBalanceIncrements clone MutableVector 300000 420.00 ns/op 357.00 ns/op 1.18
effectiveBalanceIncrements rw all Uint8Array 300000 168.29 us/op 162.88 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 82.881 ms/op 76.726 ms/op 1.08
phase0 afterProcessEpoch - 250000 vs - 7PWei 109.07 ms/op 112.94 ms/op 0.97
phase0 beforeProcessEpoch - 250000 vs - 7PWei 32.507 ms/op 40.251 ms/op 0.81
altair processEpoch - mainnet_e81889 331.11 ms/op 313.11 ms/op 1.06
mainnet_e81889 - altair beforeProcessEpoch 62.127 ms/op 67.412 ms/op 0.92
mainnet_e81889 - altair processJustificationAndFinalization 16.950 us/op 16.435 us/op 1.03
mainnet_e81889 - altair processInactivityUpdates 5.3551 ms/op 5.4217 ms/op 0.99
mainnet_e81889 - altair processRewardsAndPenalties 69.335 ms/op 67.649 ms/op 1.02
mainnet_e81889 - altair processRegistryUpdates 2.8660 us/op 3.1020 us/op 0.92
mainnet_e81889 - altair processSlashings 588.00 ns/op 427.00 ns/op 1.38
mainnet_e81889 - altair processEth1DataReset 578.00 ns/op 479.00 ns/op 1.21
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2578 ms/op 1.2096 ms/op 1.04
mainnet_e81889 - altair processSlashingsReset 4.8800 us/op 4.9550 us/op 0.98
mainnet_e81889 - altair processRandaoMixesReset 4.2760 us/op 4.3320 us/op 0.99
mainnet_e81889 - altair processHistoricalRootsUpdate 638.00 ns/op 578.00 ns/op 1.10
mainnet_e81889 - altair processParticipationFlagUpdates 2.4830 us/op 2.4140 us/op 1.03
mainnet_e81889 - altair processSyncCommitteeUpdates 565.00 ns/op 453.00 ns/op 1.25
mainnet_e81889 - altair afterProcessEpoch 116.10 ms/op 117.56 ms/op 0.99
phase0 processEpoch - mainnet_e58758 316.38 ms/op 318.35 ms/op 0.99
mainnet_e58758 - phase0 beforeProcessEpoch 118.93 ms/op 121.75 ms/op 0.98
mainnet_e58758 - phase0 processJustificationAndFinalization 15.747 us/op 15.925 us/op 0.99
mainnet_e58758 - phase0 processRewardsAndPenalties 57.020 ms/op 55.373 ms/op 1.03
mainnet_e58758 - phase0 processRegistryUpdates 7.8310 us/op 9.0330 us/op 0.87
mainnet_e58758 - phase0 processSlashings 564.00 ns/op 471.00 ns/op 1.20
mainnet_e58758 - phase0 processEth1DataReset 579.00 ns/op 497.00 ns/op 1.16
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 980.00 us/op 939.68 us/op 1.04
mainnet_e58758 - phase0 processSlashingsReset 3.1870 us/op 3.4100 us/op 0.93
mainnet_e58758 - phase0 processRandaoMixesReset 4.4750 us/op 4.3570 us/op 1.03
mainnet_e58758 - phase0 processHistoricalRootsUpdate 653.00 ns/op 574.00 ns/op 1.14
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9810 us/op 3.6130 us/op 1.10
mainnet_e58758 - phase0 afterProcessEpoch 95.384 ms/op 94.035 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1907 ms/op 1.2039 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.3712 ms/op 1.3397 ms/op 1.02
altair processInactivityUpdates - 250000 normalcase 20.263 ms/op 20.276 ms/op 1.00
altair processInactivityUpdates - 250000 worstcase 21.769 ms/op 22.420 ms/op 0.97
phase0 processRegistryUpdates - 250000 normalcase 6.0200 us/op 6.6500 us/op 0.91
phase0 processRegistryUpdates - 250000 badcase_full_deposits 230.17 us/op 236.44 us/op 0.97
phase0 processRegistryUpdates - 250000 worstcase 0.5 121.79 ms/op 123.09 ms/op 0.99
altair processRewardsAndPenalties - 250000 normalcase 58.181 ms/op 47.814 ms/op 1.22
altair processRewardsAndPenalties - 250000 worstcase 59.854 ms/op 52.362 ms/op 1.14
phase0 getAttestationDeltas - 250000 normalcase 6.4317 ms/op 6.4781 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 6.4876 ms/op 6.3038 ms/op 1.03
phase0 processSlashings - 250000 worstcase 3.3754 ms/op 3.4932 ms/op 0.97
altair processSyncCommitteeUpdates - 250000 174.45 ms/op 169.78 ms/op 1.03
BeaconState.hashTreeRoot - No change 260.00 ns/op 265.00 ns/op 0.98
BeaconState.hashTreeRoot - 1 full validator 50.051 us/op 48.559 us/op 1.03
BeaconState.hashTreeRoot - 32 full validator 494.76 us/op 468.17 us/op 1.06
BeaconState.hashTreeRoot - 512 full validator 5.4274 ms/op 5.5215 ms/op 0.98
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.191 us/op 61.780 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 917.54 us/op 876.36 us/op 1.05
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.059 ms/op 11.410 ms/op 0.97
BeaconState.hashTreeRoot - 1 balances 47.563 us/op 49.292 us/op 0.96
BeaconState.hashTreeRoot - 32 balances 431.43 us/op 442.19 us/op 0.98
BeaconState.hashTreeRoot - 512 balances 4.2931 ms/op 4.2372 ms/op 1.01
BeaconState.hashTreeRoot - 250000 balances 76.201 ms/op 72.885 ms/op 1.05
aggregationBits - 2048 els - zipIndexesInBitList 16.332 us/op 16.386 us/op 1.00
regular array get 100000 times 32.530 us/op 31.967 us/op 1.02
wrappedArray get 100000 times 32.443 us/op 31.940 us/op 1.02
arrayWithProxy get 100000 times 16.312 ms/op 15.924 ms/op 1.02
ssz.Root.equals 526.00 ns/op 531.00 ns/op 0.99
byteArrayEquals 526.00 ns/op 527.00 ns/op 1.00
shuffle list - 16384 els 6.8420 ms/op 6.7966 ms/op 1.01
shuffle list - 250000 els 100.48 ms/op 99.700 ms/op 1.01
processSlot - 1 slots 9.1780 us/op 8.7170 us/op 1.05
processSlot - 32 slots 1.3206 ms/op 1.3179 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 34.040 ms/op 33.081 ms/op 1.03
getCommitteeAssignments - req 1 vs - 250000 vc 2.8931 ms/op 2.8349 ms/op 1.02
getCommitteeAssignments - req 100 vs - 250000 vc 4.1021 ms/op 4.0178 ms/op 1.02
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4686 ms/op 4.3329 ms/op 1.03
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.4400 ns/op 4.3900 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 925.65 ns/op 938.51 ns/op 0.99
computeProposers - vc 250000 10.437 ms/op 10.405 ms/op 1.00
computeEpochShuffling - vc 250000 99.866 ms/op 99.047 ms/op 1.01
getNextSyncCommittee - vc 250000 173.98 ms/op 169.49 ms/op 1.03
computeSigningRoot for AttestationData 13.392 us/op 13.445 us/op 1.00
hash AttestationData serialized data then Buffer.toString(base64) 2.3641 us/op 2.4036 us/op 0.98
toHexString serialized data 1.0604 us/op 1.0568 us/op 1.00
Buffer.toString(base64) 313.43 ns/op 330.06 ns/op 0.95

by benchmarkbot/action

philknows
philknows reviewed Apr 15, 2023
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
@wemeetagain @philknows
Update RELEASE.md
6cbf409 
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
nflaig
nflaig reviewed Apr 15, 2023
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@wemeetagain @nflaig
Apply suggestions from code review
fcbf222 
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
@wemeetagain wemeetagain merged commit 42ecf97 into unstable Apr 15, 2023
@wemeetagain wemeetagain deleted the cayman/minor-release-from-stable branch April 15, 2023 20:29
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig left review comments

@philknows philknows philknows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wemeetagain @nflaig @philknows