Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow release from stable in release process #5367

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Allow release from stable in release process #5367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b96273
Allow release from `stable` in release process
wemeetagain Apr 15, 2023
6cbf409
Update RELEASE.md
wemeetagain Apr 15, 2023
fcbf222
Apply suggestions from code review
wemeetagain Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The causes for a release are varied, however here are several common ones:
- To include a major bug-fix, optimization, or feature.
- To include a series of small changes which have shown to improve performance, usability, etc.
- If significant or risky PRs are waiting to merge and we wish to try and isolate those changes to a future release. I.e., to leave a "clean slate" for future PRs to apply to.
- An external team or entity needs a specific feature that the team has agreed to publish.

To start a new release, one of the Lodestar developers will communicate this via the Lodestar chat channel and seek consensus from the other developers.

Expand All @@ -23,6 +24,7 @@ To start a new release, one of the Lodestar developers will communicate this via
#### All-in-one script (for example version `v1.1.0`, commit `9fceb02`):

- The team selects a commit from `unstable` as a "release candidate" for a new version release.
- NOTE: In some rare circumstances, the team may select a commit from `stable`. This may happen if a tight deadline needs to be met and `unstable` can't be stabilized in time. We should avoid doing this unless absolutely necessary as merge conflicts and unintended consequences of cherry-picking commits may arise.
- `yarn release:create-rc 1.1.0 9fceb02`
- Must be run locally from a write-access account capable of triggering CI.
- This script may alternatively be run on the checked out `HEAD`:
Expand Down