Encryption, take 5 #227
Merged
Encryption, take 5 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To explain how does it work: The public key is uploaded on web server, and is accessible by everyone. Private key on the other hand is only on bot's side, and only chaos can decrypt messages encrypted with it. |
|
🙆♀️ PR passed with a vote of 6 for and 0 against, with a weighted total of 6.0 and a threshold of 3.7. See merge-commit d9d1c77 for more details. |
chaosbot
added a commit
that referenced
this pull request
May 25, 2017
amoffat
added a commit
to amoffat/Chaos
that referenced
this pull request
May 25, 2017
@sorcio caught reqs that don't need to be there, like flask and its deps. some of the new reqs there now are actually deps from the cryptography package that weren't there from Chaosthebot#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I hope this passes, with all the issues that happened before.
Essentially, this adds asymmetric encryption for hiding stuff like API keys in plain sight.