Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document decrypt function #321

Closed

Conversation

KamilaBorowska
Copy link
Contributor

No description provided.

encryption.py Outdated
>>> from cryptography.hazmat.primitives.serialization import load_pem_public_key
>>> pkey = load_pem_public_key(open("server/pubkey.txt", "rb").read(), default_backend())
>>> message = b"Hello, world!"
>>> encrypted = pkey.encrypt(message, padding.OAEP(padding.MGF1(hashes.SHA1()), hashes.SHA1(), None))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis is not happy with this line 😞

@davidak
Copy link
Contributor

davidak commented May 27, 2017

@xfix what is your motivation for this change?

@KamilaBorowska
Copy link
Contributor Author

@davidak: Just documenting that function, as it is good programming practice.

@davidak
Copy link
Contributor

davidak commented May 27, 2017

@xfix ah, i see. thought you add a function to decrypt a document.

@KamilaBorowska
Copy link
Contributor Author

KamilaBorowska commented May 27, 2017

@davidak: This is essentially documenting usage of #227, contributed earlier. Essentially, it's to keep API keys secret, as they cannot be trusted to not be used to take over an account in a public repository. Public key to encrypt stuff can be downloaded from http://chaosthebot.com/pubkey.txt.

@chaosbot
Copy link
Collaborator

🙅 PR rejected with a vote of 5 for and 0 against, with a weighted total of 5.0 and a threshold of 6.1.

Open a new PR to restart voting.

@phil-r
Copy link
Member

phil-r commented Jun 1, 2017

@xfix Do you want to reopen it? I think it's important to have for #443 for example

@phil-r
Copy link
Member

phil-r commented Jun 1, 2017

Just in case I've added documentation here: https://github.com/chaosbot/Chaos/wiki/Encryption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants