Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-434] Add translation layer for blind signing #16993

Merged
merged 16 commits into from
Jun 5, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Dec 4, 2023

This PR introduces a new TranslationLayer concept to the @clvm_streamable library enabling reconstruction from CHIP-27 APIs into more specific responses for different types of clients. CHIP-28 is one such chip and support for it is enable as well.

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Dec 4, 2023
@Quexington Quexington changed the base branch from quex.signer_protocol to quex.observer_mode December 5, 2023 18:53
@Quexington Quexington force-pushed the quex.transport_layer branch 2 times, most recently from cf4301b to 9c3ed45 Compare December 15, 2023 18:49
@github-actions github-actions bot added coverage-diff merge_conflict Branch has conflicts that prevent merge to main and removed coverage-diff labels Dec 18, 2023
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 19, 2023
@Chia-Network Chia-Network deleted a comment from github-actions bot Dec 19, 2023
@Chia-Network Chia-Network deleted a comment from github-actions bot Dec 19, 2023
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Jan 4, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 4, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 4, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 4, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 4, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 4, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 17, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 23, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2024
@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label May 11, 2024
@Quexington Quexington removed the stale-pr Flagged as stale and in need of manual review label May 13, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 13, 2024
@Quexington Quexington changed the title Add translation layer for blind signing [CHIA-434] Add translation layer for blind signing May 14, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 22, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 23, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 23, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 23, 2024
@Quexington Quexington force-pushed the quex.execute_signing_instructions_rpc branch from c2c4a04 to efb39bf Compare May 28, 2024 21:15
Base automatically changed from quex.execute_signing_instructions_rpc to long_lived/vault June 3, 2024 21:30
@Quexington Quexington closed this Jun 3, 2024
@Quexington Quexington reopened this Jun 3, 2024
@Quexington Quexington marked this pull request as ready for review June 3, 2024 21:35
@Quexington Quexington requested a review from a team as a code owner June 3, 2024 21:35
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 4, 2024
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

File Coverage Missing Lines
chia/wallet/util/clvm_streamable.py 95.8% lines 178, 186
Total Missing Coverage
202 lines 2 lines 99%

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington merged commit 8e5add1 into long_lived/vault Jun 5, 2024
364 of 365 checks passed
@Quexington Quexington deleted the quex.transport_layer branch June 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants