Fixed cache pollution for in/nin filter expressions (#6711)

ChilliCream · Dec 11, 2023 · efcd136 · efcd136
1 parent b3e8374
commit efcd136
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/HotChocolate/Data/src/Data/Filters/Expressions/FilterExpressionBuilder.cs b/src/HotChocolate/Data/src/Data/Filters/Expressions/FilterExpressionBuilder.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
@@ -60,11 +61,14 @@ public static Expression In(
         Type genericType,
         object? parsedValue)
     {
+        var enumerableType = typeof(IEnumerable<>);
+        var enumerableGenericType = enumerableType.MakeGenericType(genericType);
+
         return Expression.Call(
             typeof(Enumerable),
             nameof(Enumerable.Contains),
             new Type[] { genericType },
-            Expression.Constant(parsedValue),
+            CreateParameter(parsedValue, enumerableGenericType),
             property);
     }