Fix cache pollution for in/nin filter expressions

[nikolai-mb]

Closes #6091

Changes FilterExpressionBuilder to use lambda expression for in/nin instead of constant.

Fixes cache pollution for EF Core queries using IN and NIN filter operators as well as database query plan pollution.

EF now creates properly parameterised queries when using these filter operators.

Example query:

query {
  cars(where: { id: { in: [ 1, 2, 3 ] } } ) {
    id
  }
}

SQL generated before this change:

      SELECT c."Id"
      FROM "Cars" AS c
      WHERE c."Id" IN (1, 2, 3)
      LIMIT @__p_0

SQL generated with changes proposed:

      SELECT c."Id"
      FROM "Cars" AS c
      WHERE c."Id" = ANY (@__p_0)
      LIMIT @__p_1

SQL samples are from postgres. This fix also applies to SQL Server which now leverages OPENJSON to parameterize arrays.

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (d92f981) 63.45%.
Report is 77 commits behind head on main.

Files	Patch %	Lines
...rization.Opa/Request/DefaultQueryRequestFactory.cs	0.00%	3 Missing ⚠️
...Abstractions/Serialization/Utf8JsonWriterHelper.cs	40.00%	3 Missing ⚠️
.../Transport.Http/GraphQLHttpEventStreamProcessor.cs	92.10%	3 Missing ⚠️
...AspNetCore/src/Transport.Http/GraphQLHttpClient.cs	71.42%	2 Missing ⚠️
...Core/Serialization/DefaultHttpResponseFormatter.cs	0.00%	1 Missing ⚠️
...pNetCore/src/Transport.Http/GraphQLHttpResponse.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6711       +/-   ##
===========================================
- Coverage   78.98%   63.45%   -15.53%     
===========================================
  Files        2903     2324      -579     
  Lines      139771   114620    -25151     
===========================================
- Hits       110397    72737    -37660     
- Misses      29374    41883    +12509     

Flag	Coverage Δ
unittests	63.45% <80.88%> (-15.53%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michaelstaib]

Hey,

thanks for contributing.

[PascalSenn]

LGTM

[PascalSenn]

@nikolai-mb Thanks for the contribution!

[MelGrubb]

Will this fix make it back to v13? We're not ready to move to 14 yet, and we're being affected by this.