Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache pollution for in/nin filter expressions #6711

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix cache pollution for in/nin filter expressions #6711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/HotChocolate/Data/src/Data/Filters/Expressions/FilterExpressionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;
Expand Down Expand Up @@ -60,11 +61,14 @@ public static Expression In(
Type genericType,
object? parsedValue)
{
var enumerableType = typeof(IEnumerable<>);
var enumerableGenericType = enumerableType.MakeGenericType(genericType);

return Expression.Call(
typeof(Enumerable),
nameof(Enumerable.Contains),
new Type[] { genericType },
Expression.Constant(parsedValue),
CreateParameter(parsedValue, enumerableGenericType),
property);
}

Expand Down
Loading