Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Strawberry shake exception handling (#4596) #6039

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Fixes Strawberry shake exception handling (#4596) #6039

merged 2 commits into from
Apr 11, 2023

Conversation

chrisdrobison
Copy link
Contributor

Pass through GraphQL errors correctly on unsuccessful HTTP response codes.

  • Attempt to parse json on any response, which will allow errors to be correctly passed through.
  • If json parsing fails, we'll ensure the status code as before

Closes #4596

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@michaelstaib michaelstaib merged commit 8602b2a into ChilliCream:main-version-13 Apr 11, 2023
michaelstaib added a commit that referenced this pull request Apr 11, 2023
@chrisdrobison @michaelstaib
Fixes Strawberry shake exception handling (#4596) (#6039)
820384f 
Co-authored-by: Michael Staib <michael@chillicream.com>
@chrisdrobison chrisdrobison deleted the cdr/response-exception-fix branch April 11, 2023 13:08
@PascalSenn PascalSenn mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

@brentmouritsen brentmouritsen brentmouritsen approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate 🌶️ strawberry shake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdrobison @CLAassistant @brentmouritsen @michaelstaib