Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Strawberry shake exception handling (#4596) #6039

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Fixes Strawberry shake exception handling (#4596) #6039

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a24bd5f
Fixes Strawberry shake exception handling (#4596)
chrisdrobison Apr 10, 2023
98d62a0
Fixed the fix
michaelstaib Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/StrawberryShake/Client/src/Transport.Http/ResponseEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,11 @@ public async ValueTask<bool> MoveNextAsync()
{
try
{
response.EnsureSuccessStatusCode();
Current = await stream.TryParseResponse(_abort).ConfigureAwait(false);
if (Current.Exception is not null)
{
response.EnsureSuccessStatusCode();
}
}
catch (Exception ex)
{
Expand Down