Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdownlint to CI (and ignore all rules for now) #6842

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

SeanKilleen
Copy link
Contributor

The first step in markdown linting per #5460.

Summary of the changes (Less than 80 chars)

  • Adds Markdownlint runner to GitHub Actions
  • Ignores all violations now so that we can begin to address them individually (avoids conflicts & large PRs, which stopped this effort previously).

@SeanKilleen
Copy link
Contributor Author

@glen-84 or others -- please approve this workflow when you get the chance so we can validate that it runs. 👍

The next step will be to actually begin remediating errors -- this step will free us up to parallelize that across multiple contributors.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4196aba) 70.65% compared to head (fb03673) 70.69%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6842      +/-   ##
==========================================
+ Coverage   70.65%   70.69%   +0.03%     
==========================================
  Files        2499     2499              
  Lines      126167   126167              
==========================================
+ Hits        89139    89189      +50     
+ Misses      37028    36978      -50     
Flag Coverage Δ
unittests 70.69% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

At least for now until we remediate things
@glen-84
Copy link
Collaborator

glen-84 commented Jan 21, 2024

Thanks Sean. Let's wait for Michael to approve, and then I can probably assist with the fixes.

@SeanKilleen
Copy link
Contributor Author

SeanKilleen commented Jan 21, 2024

@glen-84 I'm happy to tackle the fixes. This is just the first step in doing it methodically.

@michaelstaib, whenever you're able to approve this CI job to execute, please do. Happy to contribute again :)

@michaelstaib
Copy link
Member

Thanks @SeanKilleen for the help on this!

@michaelstaib michaelstaib merged commit edaacd0 into ChilliCream:main Jan 22, 2024
89 of 96 checks passed
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants