-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown linting: low hanging fruit #6843
Markdown linting: low hanging fruit #6843
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6843 +/- ##
==========================================
+ Coverage 69.52% 73.04% +3.52%
==========================================
Files 2481 2485 +4
Lines 125456 125526 +70
==========================================
+ Hits 87219 91691 +4472
+ Misses 38237 33835 -4402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@michaelstaib this workflow is ready for approval. @glen-84 feel free to review. You may want to go commit by commit as I address each rule in a commit. I kept this one simple, addressing mostly items around whitespace. I've incorporated the changes from the previously merged PR that adds the markdown lint support. |
website/src/docs/hotchocolate/v10/schema/custom-scalar-types.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @glen-84 comments
@glen-84 @michaelstaib fixed. |
Thank you @SeanKilleen and @glen-84 |
Summary of the changes (Less than 80 chars)
This gets some of the easiest items out of the way, to clear the room for the others.
Resolves:
Supports #5460.