Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for creating keystores folder #41

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add script for creating keystores folder #41

merged 1 commit into from
Jul 4, 2024

Conversation

mksh
Copy link
Contributor

@mksh mksh commented Jul 3, 2024

Fixes #25

@mksh mksh requested a review from kamsz July 3, 2024 13:59
@mksh mksh marked this pull request as ready for review July 3, 2024 14:00
@mksh mksh merged commit 921da4a into main Jul 4, 2024
1 of 2 checks passed
@jenpaff
Copy link
Contributor

jenpaff commented Jul 5, 2024

It looks like CI failed on this PR, think should be fixed before merging- updated settings so it cannot be merged otherwise

enterprise setups, for small and individual stakers this is not convenient,
as they need to be able to import validator keys directly into validator client.

To address such needs, `eth-staking-smith` provides convenience Python3 script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it need a separate python script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution with separate script is because eth-staking-smith itself does not work with filesystem as it stated on the readme to increase security, so all filesystem operations to make it compatible with common keystore folder are done in a separate convenience script.

@mksh mksh deleted the keystore-folder branch July 5, 2024 14:53
@mksh
Copy link
Contributor Author

mksh commented Jul 5, 2024

It looks like CI failed on this PR, think should be fixed before merging- updated settings so it cannot be merged otherwise

The cargo-deny issues are fixed in PR #45 , this PR does not touch Rust so doesn't fix them (cargo-deny was failing on master as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create guides and scripts for individual stakers
3 participants