Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for creating keystores folder #41

Merged
merged 1 commit into from
Jul 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,41 @@ You can use `eth-staking-smith` as follows to convert your address:

Note that --validator-index and --validator-start-index are two distinct parameter, the former being index of validator on Beacon chain, and the latter is the index of validator private key derived from the seed

## Exporting CLI standard output into common keystores folder format

Most validator clients recognize the keystore folder format,
produced by upstream Python deposit CLI. While `eth-staking-smith` outputs
all validator data into standard output, allowing for better security in
enterprise setups, for small and individual stakers this is not convenient,
as they need to be able to import validator keys directly into validator client.

To address such needs, `eth-staking-smith` provides convenience Python3 script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does it need a separate python script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution with separate script is because eth-staking-smith itself does not work with filesystem as it stated on the readme to increase security, so all filesystem operations to make it compatible with common keystore folder are done in a separate convenience script.

to export JSON validator output into common keystore folder format. It should
work on any box with Python 3.10+ installed.

```
mkdir validator_keys/
./target/debug/eth-staking-smith new-mnemonic --chain holesky --num_validators 2 \
--keystore_password test > validator_secrets.json
cat validator_secrets.json | python3 scripts/generate_keys_folder.py
cat validator_secrets.json | jq .mnemonic.seed > mnemonic.txt
rm validator_secrets.json
echo "MAKE SURE TO BACK UP mnemonic.text IN THE SAFE PLACE"

ls validator_keys/
deposit_data-1720014619.json keystore-m_12381_3600_0_0_0-1720014619.json keystore-m_12381_3600_1_0_0-1720014619.json
```

The contents of `validator_keys/` folder might be imported into most
validator clients, for example Lighthouse import command will look like that:

```
echo "test" > ./password.txt
lighthouse account validator import \
--network holesky --reuse-password
--directory validator_keys/ --password-file ./password.txt
```

### Command to send SignedBLSToExecutionChange request to Beacon node

```
Expand Down
69 changes: 69 additions & 0 deletions scripts/generate_keys_folder.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
#!/usr/bin/env python3

#
# This script takes JSON output of `eth-staking-smith` into stdin,
# and produces folder with deposit data and keystore files in the given
# location.
#
# Caveat: keystore_password should be specified before generating.
#

import argparse
import json
import logging
import pathlib
import sys
import time


logger = logging.getLogger(__name__)
parser = argparse.ArgumentParser("Generate eth validator keys folder")
parser.add_argument(
"output_folder",
default=pathlib.Path("validator_keys/"),
nargs="?",
help="Folder where to store deposit data",
)


def main():
args = parser.parse_args()
base_path = args.output_folder
if type(base_path) == str:
base_path = pathlib.Path(base_path)
assert base_path.exists(), "Output folder must exist"
inp = sys.stdin.read()
assert inp, "Should have value at standard input"
try:
validators = json.loads(inp)
except (KeyError, ValueError) as exc:
logger.exception("Got invalid json input")
else:
assert validators, "Should have non-empty JSON value passed"
assert (
"keystores" in validators
), "Should have non-empty keystores in eth-staking-smith output"
deposit_datas = validators["deposit_data"]
num_validators = len(deposit_datas)
print(f"Exporting {num_validators} keystores to {base_path}")
# Set path as EIP-2334 format
# https://eips.ethereum.org/EIPS/eip-2334
for idx, keystore in enumerate(validators["keystores"]):
ts = int(time.time())
purpose = "12381"
coin_type = "3600"
account = str(idx)
withdrawal_key_path = f"m/{purpose}/{coin_type}/{account}/0"
signing_key_path = f"{withdrawal_key_path}/0"
file_path = signing_key_path.replace("/", "_")
filename = f"keystore-{file_path}-{ts}.json"
with open(base_path / filename, "w") as fl:
fl.write(json.dumps(keystore))

with open(base_path / f"deposit_data-{ts}.json", "w") as fl:
fl.write(json.dumps(deposit_datas))


if __name__ == "__main__":
logging.basicConfig(stream=sys.stdout, level=logging.WARN)
main()
Loading