-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NerdFonts installer script added and consequential change to tab_data TOML file. #446
Conversation
…tab_data toml file.
curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz" | ||
|
||
# Extract and install the font | ||
mkdir -p ~/.local/share/fonts | ||
tar -xf "$HOME/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts" | ||
rm "$HOME/tmp/$font_name.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz" | |
# Extract and install the font | |
mkdir -p ~/.local/share/fonts | |
tar -xf "$HOME/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts" | |
rm "$HOME/tmp/$font_name.tar.xz" | |
curl -sSLo "/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz" | |
# Extract and install the font | |
mkdir -p ~/.local/share/fonts | |
tar -xf "/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts" | |
rm "/tmp/$font_name.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamperkowski this needs escalation_tool you cannot curl a file inside of the root file system without root permissions nvm tested it and it works, learn something new everyday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nnyyxxxx I'm pretty sure you're wrong this time. The default /tmp
permissions are drwxrwxrwt
. The t
at the end means that only the owner of a file or the root user can modify.
checkCommandRequirements "tar" | ||
|
||
# Download the font | ||
curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl: (3) URL rejected: Malformed input to a URL function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tar
and curl
are preloaded so what's the issue here.
I could not reproduce your error: curl: (3) URL rejected: Malformed input to a URL function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tar
andcurl
are preloaded so what's the issue here. I could not reproduce your error:curl: (3) URL rejected: Malformed input to a URL function
Then you did not test it, "TMP" a folder inside of the root file system does not exist inside of the users home directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename nerdfonts-installer.sh
to nerdfonts.sh
The script should also check if |
I'm sorry but I cannot approve 100% LLM generated PRs. You need to rewrite the code yourself. |
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
I used my 15" laptop and I also think even if it's 14" or 13" its okay so how can you make it |
You can use |
Shouldn't I add check for |
You should check if You can do |
I think the issue with that is if debian has other utility which installs |
…oviding the ability to scroll both forwards and backwards through the list of fonts
May be the "and if not" part be actually implemented in common-script rather than in individual cases like this... 🤔 |
You can use case $PACKAGER in
apt|nala)
# debian stuff
;;
... |
I had another one of using cli to setup |
Type of Change
Description
The NerdFonts installer script has been added, allowing users to select and install a variety of NerdFonts through a command-line interface. This feature ensures that the required fonts are downloaded and installed in the user’s
~/.local/share/fonts
directory. Additionally, the font cache is updated to reflect the changes.A consequential change has been made to the
tab_data
TOML file to integrate the new functionality and ensure smooth operation across the platform.Key Features:
less
.Testing
Impact
This feature will allow users to easily install and manage NerdFonts, reducing manual download and installation time. There are no new dependencies outside the standard utilities (
curl
,tar
,less
) except that offc-cache
fromfontconfig
.Issue related to PR
Additional Information
No additional information at this time.
Checklist