Bootloader switcher script added and consequential change to tab TOML file. #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tab_data toml file.
fam007e
changed the title
|
@fam007e I think you should rewrite the script yourself. Without using LLMs. |
12 tasks
adamperkowski
requested changes
Sep 17, 2024
Comment on lines
+17
to
+25
| detect_bootloader() { | ||
| if [ -d /boot/grub ]; then | ||
| printf "GRUB\n" | ||
| elif [ -d /boot/loader ]; then | ||
| printf "systemd-boot\n" | ||
| else | ||
| printf "Unknown\n" | ||
| fi | ||
| } |
There was a problem hiding this comment.
This should be rewritten not to use printfs or echos.
Comment on lines
+6
to
+7
| BACKUP_DIR="/boot/backup/bootloader" | ||
| TIMESTAMP=$(date +%Y%m%d-%H%M%S) |
There was a problem hiding this comment.
This shouldn't be in /boot/backup/bootloader. BOOT partitions are usually somewhat small.
Also not the best idea to have commands running here. Move this.
Comment on lines
+44
to
+66
| restore_grub() { | ||
| if [ -z "$1" ]; then | ||
| printf "${RED}Please provide the backup file for GRUB restore.${RC}\n" | ||
| exit 1 | ||
| fi | ||
|
|
||
| printf "${YELLOW}Restoring GRUB configuration from %s...${RC}\n" "$1" | ||
| $ESCALATION_TOOL tar -xzf "$1" -C / | ||
| grub-mkconfig -o /boot/grub/grub.cfg | ||
| printf "${GREEN}GRUB configuration restored.${RC}\n" | ||
| } | ||
|
|
||
| # Restore systemd-boot configuration | ||
| restore_systemd_boot() { | ||
| if [ -z "$1" ]; then | ||
| printf "${RED}Please provide the backup file for systemd-boot restore.${RC}\n" | ||
| exit 1 | ||
| fi | ||
|
|
||
| printf "${YELLOW}Restoring systemd-boot configuration from %s...${RC}\n" "$1" | ||
| $ESCALATION_TOOL tar -xzf "$1" -C / | ||
| printf "${GREEN}systemd-boot configuration restored.${RC}\n" | ||
| } |
There was a problem hiding this comment.
The script is not supposed to be ran manually. No need for func arguments.
Comment on lines
+73
to
+93
| case "$DTYPE" in | ||
| debian | ubuntu) | ||
| $ESCALATION_TOOL apt-get install -y grub-efi | ||
| grub-install | ||
| grub-mkconfig -o /boot/grub/grub.cfg | ||
| ;; | ||
| arch) | ||
| $ESCALATION_TOOL pacman -S --noconfirm grub | ||
| grub-install --target=x86_64-efi --efi-directory=/boot | ||
| grub-mkconfig -o /boot/grub/grub.cfg | ||
| ;; | ||
| fedora) | ||
| $ESCALATION_TOOL dnf install -y grub2-efi | ||
| grub2-install | ||
| grub2-mkconfig -o /boot/grub2/grub.cfg | ||
| ;; | ||
| *) | ||
| printf "${RED}Unsupported distribution for GRUB installation.${RC}\n" | ||
| exit 1 | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
- Use
$PACKAGER. - The installation should be separated and config merged into one.
Comment on lines
+101
to
+109
| case "$DTYPE" in | ||
| debian | ubuntu | arch | fedora) | ||
| $ESCALATION_TOOL bootctl install | ||
| ;; | ||
| *) | ||
| printf "${RED}Unsupported distribution for systemd-boot installation.${RC}\n" | ||
| exit 1 | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
Suggested change
| case "$DTYPE" in | |
| debian | ubuntu | arch | fedora) | |
| $ESCALATION_TOOL bootctl install | |
| ;; | |
| *) | |
| printf "${RED}Unsupported distribution for systemd-boot installation.${RC}\n" | |
| exit 1 | |
| ;; | |
| esac | |
| if ! command_exists "systemctl"; then | |
| printf "%b\n" "${RED}systemd-boot only works on systemd distros.${RC}" | |
| exit 1 | |
| fi | |
| $ESCALATION_TOOL bootctl install |
Comment on lines
+113
to
+116
| display_backup_list() { | ||
| printf "${YELLOW}Available backups:${RC}\n" | ||
| ls -1 "$BACKUP_DIR" | grep -E 'grub-backup|systemd-boot-backup' | ||
| } |
There was a problem hiding this comment.
This is used only once. No need for a function.
Comment on lines
+155
to
+158
| 3) | ||
| printf "${GREEN}Exiting.${RC}\n" | ||
| exit 0 | ||
| ;; |
| printf "${YELLOW}1) Switch to GRUB${RC}\n" | ||
| fi | ||
| printf "${YELLOW}2) Restore backup${RC}\n" | ||
| printf "${YELLOW}3) Exit${RC}\n" |
|
You should use |
2 tasks
|
You have conflicts that need fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Bootloader Switcher script provides functionality to switch between GRUB and systemd-boot bootloaders, offering automatic detection of the current bootloader, creating backups of the configurations, and restoring them when needed.
Key Features:
Consequential Change:
tab_dataTOML file has been updated to accommodate this new functionality and ensure seamless integration with the system.Testing
Impact
This script simplifies managing bootloaders, reducing manual steps for installation, backup, and restoration. The impact includes better flexibility for users on multi-boot systems or those who want to switch between bootloaders easily.
Issue related to PR
Additional Information
No additional information at this time.
Checklist