-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete Winget Install Overhaul and Progress Bar in GUI #2466
Conversation
Hey @Marterich, it looks like you removed the existing progress bar for applications with this PR, but I did not look that deep into it. Is this intended or was it overlooked? |
The Taskbar Update is still in there and now needs only a single line to be applied. |
This also fixes an issue with the taskbaritem that occurred by merging mine and another PR. This will fix the overlap. Thanks @Marterich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been trying to do this for over 2 years... Well done @Marterich
Simply amazing.
Type of Change
Description
Note
To be fair, I should have probably split this up into multiple PRs, but I got a bit carried away while creating this when I realized how badly the winget install logic was put together and that it would have been subjectively more work implementing the changes to the old one than just rewriting it completely. Then one thing led to another and now we are here...
Testing
Tested extensively on my Win11 23H2 VM but as this is quite the overhaul, more testing is recommended.
Impact
Provides a nicer way of displaying what is going on to the user and lays the foundation for completely removing the necessity of displaying the open Powershell session beside the main window.
The rework of the winget program install logic provides a more solid base to extend it in the future and also fixes the need for passing PSCustomObjects to the Install Logic for winget. Now a list of IDs is sufficient.
Checklist