Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Winget Install Overhaul and Progress Bar in GUI #2466

Merged
merged 11 commits into from
Jul 31, 2024

Conversation

Marterich
Copy link
Contributor

Type of Change

  • New feature
  • Refactoring
  • UI/UX improvement

Description

  • Complete Rework (and Rename) of the Winget install Function.
  • Adds a Progress Bar in the UI that shows the status of (e.g running installs) hidden If nothing is going on
    image
  • smaller cleanups and changes I encountered along the way

Note

To be fair, I should have probably split this up into multiple PRs, but I got a bit carried away while creating this when I realized how badly the winget install logic was put together and that it would have been subjectively more work implementing the changes to the old one than just rewriting it completely. Then one thing led to another and now we are here...

Testing

Tested extensively on my Win11 23H2 VM but as this is quite the overhaul, more testing is recommended.

Impact

Provides a nicer way of displaying what is going on to the user and lays the foundation for completely removing the necessity of displaying the open Powershell session beside the main window.

The rework of the winget program install logic provides a more solid base to extend it in the future and also fixes the need for passing PSCustomObjects to the Install Logic for winget. Now a list of IDs is sufficient.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

@MyDrift-user
Copy link
Contributor

MyDrift-user commented Jul 27, 2024

Hey @Marterich, it looks like you removed the existing progress bar for applications with this PR, but I did not look that deep into it. Is this intended or was it overlooked?
Otherwise looks good, will test it out later.

@Marterich
Copy link
Contributor Author

Hey @Marterich, it looks like you removed the existing progress bar for applications with this PR, but I did not look that deep into it. Is this intended or was it overlooked? Otherwise looks good, will test it out later.

The Taskbar Update is still in there and now needs only a single line to be applied.
Just fixed the range for the value of the taskbar item. Didn't realize that it only needs numbers between 0 and 1.

@MyDrift-user
Copy link
Contributor

This also fixes an issue with the taskbaritem that occurred by merging mine and another PR. This will fix the overlap.

Thanks @Marterich

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been trying to do this for over 2 years... Well done @Marterich
Simply amazing.

@ChrisTitusTech ChrisTitusTech merged commit e7328c2 into ChrisTitusTech:main Jul 31, 2024
@Marterich Marterich deleted the loading-bar branch July 31, 2024 16:25
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants