[02] Refactoring UI Code #2469
Merged
[02] Refactoring UI Code #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This's done to fix the Visual Issue of the Close Button being smaller than the Settings Button.
…XML Related Failures - Simple Code Formatting here & there
|
@ChrisTitusTech If you want to change anything, or wanna resolve merge conflicts, you can do so 👍 EDIT: This PR will likely get merge conflicts if @Marterich 's PR #2466 gets merged before this PR, and vise versa. |
|
|
YusufKhalifadev
approved these changes
Aug 1, 2024
…ename 'Set-WinUtilUiTheme.ps1' -> 'Set-WinUtilUITheme.ps1'
…it's displayed even in RunSpaces as well as PowerShell 5 Environments
7 tasks
ChrisTitusTech
approved these changes
Aug 26, 2024
8 tasks
ChrisTitusTech
pushed a commit
that referenced
this pull request
Aug 28, 2024
… to make PR #2629 merge easily without any problem) (#2630) * Remove leftover comment & update another comment in 'Get-TabXaml' Private Function * Add new 'CloseIconFontSize' Theme Option This's done to fix the Visual Issue of the Close Button being smaller than the Settings Button. * Rename 'CheckBoxBulletDecoratorFontSize' to 'CheckBoxBulletDecoratorSize' * Experiment with DPI Aware Units * Remove extra whitespace characters in 'theme.json' * Implement Default Theming - Add Error Checking & Quitting Early upon XML Related Failures - Simple Code Formatting here & there * Replace Tabs with Spaces to follow the conventions * Fix some logic issue in 'Set-WinUtilUITheme.ps1' Private Function - Rename 'Set-WinUtilUiTheme.ps1' -> 'Set-WinUtilUITheme.ps1' * Change output info from 'Write-Warning' to 'Write-Host' to make sure it's displayed even in RunSpaces as well as PowerShell 5 Environments * Revert back to default Unit of Measuring for WPF (1/96 in) * Revert "Remove leftover comment & update another comment in 'Get-TabXaml' Private Function" This reverts commit 368e598. * Update 'themes.json' so the general changes will work with PR #2629 * Support the fallback to default theme (if it exists) * Update 'Set-WinUtilUITheme' Documentation --------- Co-authored-by: MyDrift <personal@mdiana.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Second PR in UI Refactoring Series.
Type of Change
Description
Implements the Default Theming Idea I had when I opened issue #2226, and although I must say that this PR is alot smaller in code changes / Impact on End User.. but I do think it's a something overlooked, and can be improved upon (there's still room for improvement even after this PR).
Testing
WinUtil compiles & runs successfully, and the theming looks correct (as far as I can tell).
Impact
End user won't feel any difference, but when adding or updating theming options across different themes.. this can be done with ease by simply changing the
_defaulttheme.Additional Information
I haven't tested startup time difference before & after changes, but due to the increased error checking & other changes as well.. I won't be surprised if it's increased by a small margin.
Checklist