-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring UI Code] WIP: Inline UI Definition instead of xaml compilation #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mr.k <mineshtine28546271@gmail.com>
Co-authored-by: Mr.k <mineshtine28546271@gmail.com>
* Remove the Special Character Escaping for Json Files as there's no need for it anymore * Simplify 'application.json' Json Prefix Addition in 'Compile.ps1' Script Thanks to @fam007e for improving this section in his PR ChrisTitusTech#2587 changes Co-authored-by: fam007e <faisalmoshiur@gmail.com> --------- Co-authored-by: fam007e <faisalmoshiur@gmail.com>
og-mrk
added a commit
to og-mrk/winutil
that referenced
this pull request
Aug 26, 2024
og-mrk
pushed a commit
to og-mrk/winutil
that referenced
this pull request
Aug 27, 2024
ChrisTitusTech
pushed a commit
that referenced
this pull request
Aug 28, 2024
… to make PR #2629 merge easily without any problem) (#2630) * Remove leftover comment & update another comment in 'Get-TabXaml' Private Function * Add new 'CloseIconFontSize' Theme Option This's done to fix the Visual Issue of the Close Button being smaller than the Settings Button. * Rename 'CheckBoxBulletDecoratorFontSize' to 'CheckBoxBulletDecoratorSize' * Experiment with DPI Aware Units * Remove extra whitespace characters in 'theme.json' * Implement Default Theming - Add Error Checking & Quitting Early upon XML Related Failures - Simple Code Formatting here & there * Replace Tabs with Spaces to follow the conventions * Fix some logic issue in 'Set-WinUtilUITheme.ps1' Private Function - Rename 'Set-WinUtilUiTheme.ps1' -> 'Set-WinUtilUITheme.ps1' * Change output info from 'Write-Warning' to 'Write-Host' to make sure it's displayed even in RunSpaces as well as PowerShell 5 Environments * Revert back to default Unit of Measuring for WPF (1/96 in) * Revert "Remove leftover comment & update another comment in 'Get-TabXaml' Private Function" This reverts commit 368e598. * Update 'themes.json' so the general changes will work with PR #2629 * Support the fallback to default theme (if it exists) * Update 'Set-WinUtilUITheme' Documentation --------- Co-authored-by: MyDrift <personal@mdiana.ch>
ChrisTitusTech
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (Requires #2630 to be merged first)
Note
This PR is a reopened version of #2465 and was made compatible with #2630 in work with @og-mrk.
For this PR to not cause Issues and work while testing, I suggest merging #2630 first.
inline ui build
Type of Change
Description
Instead of compiling the jsons to xaml, we could take them and build the ui from a runspace with code.
automation will not have to wait on UI elements to load, because with a WIP PR it will be disabled on automation.
refractor ui generation that is already defined in json
general little UI improvements across winutil (positioning, margin, padding ..)
optimize search
fix ui of search
Before:
After:
use proper theming everywhere
Impact:
Plans for future:
Additional Information
This PR is a WIP, I made it very early in dev process to get feedback and let people know what i am up to because this will change a lot (logics of building the GUI)
Checklist