Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[02] Refactoring code (Reopening of PR #2469, plus some modifications to make PR #2629 merge easily without any problem) #2630

Merged
merged 18 commits into from
Aug 28, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Aug 26, 2024

More Details on changes?

This PR is basically the same as PR #2469, but with the following simple changes:

  • Had to revert simple changes in Get-TabXaml function, as this function will be removed by @MyDrift-user 's Refactoring PR, making the merging process for both PRs alot better. ( commit 4a89626 )
  • @MyDrift-user and I have agreed on a solution to fix the upcoming Merge Conflicts related to themes.json File.. which's transferring some of his code changes into this PR.. I made sure to give proper credit to these changes by making him the commit author of those changes. ( commit 591675e )
  • other then that.. nothing else, see more details about changes in the next section(s).

Title

Second PR in UI Refactoring Series.

Type of Change

  • New feature
  • Refactoring
  • UI/UX improvement

Description

Implements the Default Theming Idea I had when I opened issue #2226, and although I must say that this PR is alot smaller in code changes / Impact on End User.. but I do think it's a something overlooked, and can be improved upon (there's still room for improvement even after this PR).

Testing

WinUtil compiles & runs successfully, and the theming looks correct (as far as I can tell).

Impact

End user won't feel any difference, but when adding or updating theming options across different themes.. this can be done with ease by simply changing the _default theme.

Additional Information

I haven't tested startup time difference before & after changes, but due to the increased error checking & other changes as well.. I won't be surprised if it's increased by a small margin.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@og-mrk og-mrk force-pushed the refactoring-code-02 branch from a4577ee to 591675e Compare August 27, 2024 10:37
@ChrisTitusTech ChrisTitusTech merged commit 322d527 into ChrisTitusTech:main Aug 28, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
@og-mrk og-mrk deleted the refactoring-code-02 branch September 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants