-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[02] Refactoring code (Reopening of PR #2469, plus some modifications to make PR #2629 merge easily without any problem) #2630
Merged
ChrisTitusTech
merged 18 commits into
ChrisTitusTech:main
from
og-mrk:refactoring-code-02
Aug 28, 2024
Merged
[02] Refactoring code (Reopening of PR #2469, plus some modifications to make PR #2629 merge easily without any problem) #2630
ChrisTitusTech
merged 18 commits into
ChrisTitusTech:main
from
og-mrk:refactoring-code-02
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This's done to fix the Visual Issue of the Close Button being smaller than the Settings Button.
…XML Related Failures - Simple Code Formatting here & there
…ename 'Set-WinUtilUiTheme.ps1' -> 'Set-WinUtilUITheme.ps1'
…it's displayed even in RunSpaces as well as PowerShell 5 Environments
…aml' Private Function" This reverts commit 368e598.
7 tasks
og-mrk
force-pushed
the
refactoring-code-02
branch
from
August 27, 2024 10:37
a4577ee
to
591675e
Compare
ChrisTitusTech
approved these changes
Aug 28, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More Details on changes?
This PR is basically the same as PR #2469, but with the following simple changes:
Get-TabXaml
function, as this function will be removed by @MyDrift-user 's Refactoring PR, making the merging process for both PRs alot better. ( commit 4a89626 )themes.json
File.. which's transferring some of his code changes into this PR.. I made sure to give proper credit to these changes by making him the commit author of those changes. ( commit 591675e )Title
Second PR in UI Refactoring Series.
Type of Change
Description
Implements the Default Theming Idea I had when I opened issue #2226, and although I must say that this PR is alot smaller in code changes / Impact on End User.. but I do think it's a something overlooked, and can be improved upon (there's still room for improvement even after this PR).
Testing
WinUtil compiles & runs successfully, and the theming looks correct (as far as I can tell).
Impact
End user won't feel any difference, but when adding or updating theming options across different themes.. this can be done with ease by simply changing the
_default
theme.Additional Information
I haven't tested startup time difference before & after changes, but due to the increased error checking & other changes as well.. I won't be surprised if it's increased by a small margin.
Checklist