[Refactoring UI Code] WIP: Inline UI Definition instead of xaml compilation #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MyDrift-user
changed the title
og-mrk
reviewed
Aug 9, 2024
2 tasks
og-mrk
reviewed
Aug 21, 2024
Co-authored-by: Mr.k <mineshtine28546271@gmail.com>
og-mrk
approved these changes
Aug 22, 2024
8 tasks
* Remove the Special Character Escaping for Json Files as there's no need for it anymore * Simplify 'application.json' Json Prefix Addition in 'Compile.ps1' Script Thanks to @fam007e for improving this section in his PR ChrisTitusTech#2587 changes Co-authored-by: fam007e <faisalmoshiur@gmail.com> --------- Co-authored-by: fam007e <faisalmoshiur@gmail.com>
6 tasks
6 tasks
ChrisTitusTech
approved these changes
Aug 26, 2024
7 tasks
ChrisTitusTech
added a commit
that referenced
this pull request
Aug 28, 2024
…lation (#2629) * try1: apps panel * refractor - removed Get-TabXaml.ps1 - removed compilation part from compile.ps1 - removed existing changes from main.ps1 - added Invoke-WinUtilUIElements.ps1 - refractor existing changes into new function - modified inputXML to call function * removed unused replacementlogics * fix toggle style * move naming from winutil to wpf * hotfixes - reworked function calling - working on correct theming support * hotfix * hotfix fix missing elements fix var naming * some fixes * hotfixes * add image logic * fix ? issue in search * filter out unneeded categories * cleanup * fix border styling * fixes * preprocessing * fix typo * last fixes & add notes * Update functions/public/Invoke-WPFUIElements.ps1 Co-authored-by: Mr.k <mineshtine28546271@gmail.com> * fix margin * fix tabcontent margin * fix some other margin issues * move fixed values outside of iterations * little fix * add Dispatcher.Invoke * add error handling for styles * Update functions/public/Invoke-WPFUIElements.ps1 Co-authored-by: Mr.k <mineshtine28546271@gmail.com> * remove dispatcher * fix search * move run & undo tweaks to be fixed * add error handling * fix throw exception * fixed accidental removal of findname grid call * add padding & margin to make search look good * remove grid to make it look correctly on small window * fix rectangle * Compiler Improvements for PR #2465 (#7) * Remove the Special Character Escaping for Json Files as there's no need for it anymore * Simplify 'application.json' Json Prefix Addition in 'Compile.ps1' Script Thanks to @fam007e for improving this section in his PR #2587 changes Co-authored-by: fam007e <faisalmoshiur@gmail.com> --------- Co-authored-by: fam007e <faisalmoshiur@gmail.com> * fix margin of search clear * fix cursor on clear search button * undo fixed run & undo * refractor themes.json * undo themes.json --------- Co-authored-by: Mr.k <mineshtine28546271@gmail.com> Co-authored-by: fam007e <faisalmoshiur@gmail.com> Co-authored-by: Chris Titus <contact@christitus.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request CONFLICTS WITH #2469
Warning
@ChrisTitusTech, og-mrk's PR linked on top will refractor themes.json, meaning his or my Changes will be undone. could
you please look at fixing it?
Warning
@ChrisTitusTech it has "conflicts" cause og-mrk's refractors themes.json, i am adding stuff to it which will be overwritten with his PR and crash/have wrong values
gets merged
inline ui build
Type of Change
Description
Instead of compiling the jsons to xaml, we could take them and build the ui from a runspace with code.
automation will not have to wait on UI elements to load, because with a WIP PR it will be disabled on automation.
refractor ui generation that is already defined in json
general little UI improvements across winutil (positioning, margin, padding ..)
optimize search
fix ui of search
Before:
After:
use proper theming everywhere
Impact:
Plans for future:
Additional Information
This PR is a WIP, I made it very early in dev process to get feedback and let people know what i am up to because this will change a lot (logics of building the GUI)
Checklist