Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goci lint #249

Closed

Conversation

jenny-miggin
Copy link

@jenny-miggin jenny-miggin commented Aug 10, 2023

Description

Bump the version of golangci_lint

Reasons

This includes fixes included in this PR

Checklist

Please check through the following before opening your PR. Thank you!

  • I have made changes to the Dockerfile.template file only
  • I have not made any manual changes to automatically generated files
  • My PR follows best practices as described in the contributing guidelines
  • (Optional, but recommended) My commits are signed

@jenny-miggin jenny-miggin requested a review from a team as a code owner August 10, 2023 11:42
@PetarKaukov
Copy link

PetarKaukov commented Aug 17, 2023

This should be merged ASAP.

The current 1.21.0 image uses golangci-lint 1.53.3 which is built against go 1.20 and fails when linting go 1.21 code.

@jenny-miggin you might want to bump the version to 1.54.1 as it introduces some small updates and is the most recent version.

@JalexChen
Copy link
Contributor

Looks like this is associated with a bunch of upstream issues related to the go1.21 release, kubernetes, ruleguard, and go critic. i took a look through all the associated issues which seem to either be closed or the fixes merged.

my main worry was whether we would need to have two different gocilint versions for older versions of go images because of the breaking change, but looks like the upstream PR accounts for it here

@BytesGuy @ryanbourdais since this is breaking people's builds and because 1.54.x is what should be used for 1.21, i am in favor of re-releasing this image once this is merged in.

@jenny-miggin - if you are able to update the golint-ci version to 1.54.2, that would be greatly appreciated. if not, i'll check back on 8/23 and create a PR off your changes so you get credit as a contributor.

@JalexChen JalexChen mentioned this pull request Aug 23, 2023
4 tasks
@JalexChen
Copy link
Contributor

Closing in favor of #250 per my last comment

@JalexChen JalexChen closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants