Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v1.21.0 [release] #250

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Publish v1.21.0 [release] #250

merged 2 commits into from
Aug 23, 2023

Conversation

JalexChen
Copy link
Contributor

@JalexChen JalexChen commented Aug 23, 2023

For our official CircleCI Docker Convenience Image support policy, please see CircleCI docs.

This policy outlines the release, update, and deprecation policy for CircleCI Docker Convenience Images.


Description

Re-release Go 1.21 due to issues raised in this PR pertaining to breaking changes related to upstream packages for go-critic, kubernetes, and gocilint

Reasons

Please provide reasoning for these changes and how this PR achieves them.

  • Provided feedback on the PR and gave time for a rebase on the branch. Incorporated their PR so they get contribution credit
  • Per my comments on the PR, the breaking changes should necessitate a re-release to prevent breaking builds due to the linter

If applicable, include a link to the related GitHub issue that this PR will close.

Checklist

Please check through the following before opening your PR. Thank you!

  • I have made changes to the Dockerfile.template file only
  • I have not made any manual changes to automatically generated files
  • My PR follows best practices as described in the contributing guidelines
  • (Optional, but recommended) My commits are signed

@JalexChen JalexChen requested a review from a team as a code owner August 23, 2023 17:29
@JalexChen JalexChen mentioned this pull request Aug 23, 2023
4 tasks
@JalexChen JalexChen enabled auto-merge (squash) August 23, 2023 17:32
Copy link

@ryanbourdais ryanbourdais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JalexChen JalexChen merged commit dc0a9a4 into main Aug 23, 2023
1 check passed
@JalexChen JalexChen deleted the re-release-1.21 branch August 23, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants