Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to v1.11 and use modules instead of godep #221

Merged
merged 10 commits into from
Dec 5, 2018
Merged

Upgrade Go to v1.11 and use modules instead of godep #221

merged 10 commits into from
Dec 5, 2018

Conversation

zzak
Copy link
Contributor

@zzak zzak commented Dec 3, 2018

Thanks to Russ Cox for this comment which made it very easy to migrate:
golang/dep#1959 (comment)

@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   27.02%   27.02%           
=======================================
  Files          21       21           
  Lines        2390     2390           
=======================================
  Hits          646      646           
  Misses       1671     1671           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8266a1...9d93ca3. Read the comment docs.

@zzak zzak force-pushed the go111 branch 3 times, most recently from 2837c5c to c3934a0 Compare December 3, 2018 10:21
@zzak zzak force-pushed the go111 branch 2 times, most recently from 204f86e to 7e2bde4 Compare December 3, 2018 12:16
Thanks to @dnephin who already solved this for us over a year ago:
alecthomas/gometalinter#149 (comment)
@zzak zzak requested a review from dnephin December 3, 2018 12:39
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzak zzak merged commit 1b39312 into master Dec 5, 2018
@zzak zzak deleted the go111 branch December 5, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants