Generate Resource and Datasource for Netflow Exporter Policy. #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tributes that are slices of strings.
… Modify resource.go.tmpl to allow empty list as input. Modify test templates to check for attributes set to empty list.
…in documentation.
…Policy. Enable functionality to add test values in resource_required and datasource_required for attributes that are not required.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1240 +/- ##
==========================================
+ Coverage 87.03% 87.16% +0.12%
==========================================
Files 43 45 +2
Lines 11223 11846 +623
==========================================
+ Hits 9768 10325 +557
- Misses 991 1034 +43
- Partials 464 487 +23 ☔ View full report in Codecov by Sentry. |
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
samiib
requested changes
Jun 25, 2024
gmicol
requested review from
samiib
and removed request for
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.