Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

158/remove application references #438

Merged
merged 6 commits into from
Aug 21, 2021
Merged

158/remove application references #438

merged 6 commits into from
Aug 21, 2021

Conversation

willrlin
Copy link

@willrlin willrlin commented Aug 20, 2021 •
edited
Loading

Issue

Description

Removes application information from the partner portal in 3 places:

  1. Listings page view
    Before
    Screen Shot 2021-08-20 at 12 23 29 PM

After
Screen Shot 2021-08-20 at 12 23 54 PM

  1. Single listing view
    Removed section:
    Screen Shot 2021-08-20 at 12 22 39 PM

  2. Edit listing view
    Removed section:
    Screen Shot 2021-08-20 at 12 23 02 PM

Also stops setting applications on Detroit seed listings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Can This Be Tested/Reviewed?

Tested locally.

  • Desktop View
  • Mobile View - the partner portal looks terrible in Mobile view anyway, but I did make sure the edits worked.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@willrlin willrlin requested a review from abbiefarr August 20, 2021 16:42
@willrlin willrlin merged commit 69b03fa into main Aug 21, 2021
@willrlin willrlin deleted the 158/remove-application-references branch August 21, 2021 02:08
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
@willrlin
158/remove application references (#438)
9f20e68 
* Remove seeding applications for Detroit properties.

* Fix the partner portal address.

* Remove the applications from the partner listings view.

* Cleanup imports

* Remove applications dates from listing edit form.

* Edit CHANGELOG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiefarr abbiefarr abbiefarr approved these changes

Assignees

@abbiefarr abbiefarr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove (or turn off?) all references to Listing.applicationDueDate
2 participants
@willrlin @abbiefarr