Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: make gpu memory collection configurable #835

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Follow-up to #794, this makes GPU memory collection toggleable.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 18.73% // Head: 18.82% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (a75fe45) compared to base (bd35bbd).
Patch coverage: 28.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   18.73%   18.82%   +0.08%     
==========================================
  Files          71       71              
  Lines       13493    13500       +7     
==========================================
+ Hits         2528     2541      +13     
+ Misses      10965    10959       -6     
Impacted Files Coverage Δ
src/app.rs 0.00% <ø> (ø)
src/app/data_harvester.rs 0.00% <0.00%> (ø)
src/app/data_harvester/memory/general/heim.rs 0.00% <0.00%> (ø)
src/app/layout_manager.rs 62.50% <ø> (ø)
src/canvas/widgets/mem_basic.rs 0.00% <0.00%> (ø)
src/options.rs 42.23% <0.00%> (+0.84%) ⬆️
src/clap.rs 100.00% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the optionable_gpu_memory branch from f2bcfb4 to a75fe45 Compare October 15, 2022 20:20
@ClementTsang ClementTsang marked this pull request as ready for review October 15, 2022 20:49
@ClementTsang ClementTsang merged commit a949740 into master Oct 15, 2022
@ClementTsang ClementTsang deleted the optionable_gpu_memory branch October 15, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants