enable gpu mem cli and update docs for arc/gpu mem #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 18.82% // Head: 18.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
=======================================
Coverage 18.82% 18.82%
=======================================
Files 71 71
Lines 13500 13495 -5
=======================================
Hits 2541 2541
+ Misses 10959 10954 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementTsang
approved these changes
Oct 16, 2022
|
LGTM. Thanks for the changes! |
|
@all-contributors please add @jamartin9 for doc. |
|
I've put up a pull request to add @jamartin9! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables use of cli argument
enable_gpu_memoryand adds it to the default config file.Updates some of the docs for arc/gpu styles, gpu flag and gpu cli flag.
Issue
Follow-up to #794 and #835
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)I did NOT update the changelog.
Feel free to close if unwanted.