Cleanup if statement in player_activity::can_resume_with

CleverRaven · May 5, 2020 · ab3921e · ab3921e
1 parent ba115ae
commit ab3921e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/player_activity.cpp b/src/player_activity.cpp
@@ -305,7 +305,9 @@ bool player_activity::can_resume_with( const player_activity &other, const Chara
         return false;
     }
 
-    if( actor && other.actor && id() == other.id() ) {
+    // if actor XOR other.actor then id() != other.id() so
+    // we will correctly return false based on final return statement
+    if( actor && other.actor ) {
         return actor->can_resume_with( *other.actor, who );
     }