Skip to content

Commit

Permalink
Correct logic for -Wno-unknown-warning-option (#58523)
Browse files Browse the repository at this point in the history
* Correct logic for -Wno-unknown-warning-option

It looks like both AppleClang and LLVM Clang use
-Wno-unknown-warning-option instead of -Wno-unknown-warning, so this
updates the logic from b1e5ada to match that. It'd probably also be
possible to just add both -Wno-unknown-warning and
-Wno-unknown-warning-option, but who knows.

* Quote in if condition of CMakeLists.txt

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
  • Loading branch information
perryprog and Qrox authored Jun 20, 2022
1 parent cda1e75 commit cb3447c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ else ()
-Wsuggest-override \
-Wunused-macros \
-Wzero-as-null-pointer-constant")
if(Clang STREQUAL ${CMAKE_CXX_COMPILER_ID})
if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
set(CATA_WARNINGS "${CATA_WARNINGS} -Wno-unknown-warning-option")
else()
set(CATA_WARNINGS "${CATA_WARNINGS} -Wno-unknown-warning")
Expand Down

0 comments on commit cb3447c

Please sign in to comment.