Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plows and Rockwheels can be converted into JSON effects #26324

Closed
Xion350 opened this issue Oct 19, 2018 · 2 comments
Closed

Plows and Rockwheels can be converted into JSON effects #26324

Xion350 opened this issue Oct 19, 2018 · 2 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions

Comments

@Xion350
Copy link
Contributor

Xion350 commented Oct 19, 2018

As per @mlangsdorf from the Discord.

So the plow and the rockwheel use copy-pasta of the same code. It could be generalized to take a JSON configuration, something like "transform_tiles": { "base_flag": "DIGGABLE", "new_terrain": "pit_shallow", "failure_damages": true }.

Having this effect in JSON would be useful as you could create vehicle parts that do more than just till earth. The original suggestion was from someone who wanted a vehicle part that could create roads.

@mlangsdorf mlangsdorf added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` labels Oct 19, 2018
@KnightosMaster
Copy link
Contributor

This functionality now exists in the form of transform_terrain, and should probably be closed. @mlangsdorf

@ZhilkinSerg
Copy link
Contributor

It was jsonized in PRs like #31894 and #31913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

No branches or pull requests

4 participants