Faction base recipe from SD-card

[Melodeiro]

Describe the bug

I just got a weird recipe from Science SD-card

Steps To Reproduce

Probably it just randoms any recipes, including fake ones from faction bases

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 1607
• Game Version: 0.D-6568-gffec12f [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Aftershock [aftershock],
  DeadLeaves' Fictional Guns [FIC_Weapons],
  More Survival Tools [More_Survival_Tools],
  Makeshift Items Mod [makeshift],
  Garden Pots [growable-pots],
  Modular Turrets [modular_turrets],
  Salvaged Robots [Salvaged_Robots],
  Mining Mod [Mining_Mod],
  Mutant NPCs [mutant_npcs],
  Alternative Map Key [alt_map_key],
  Hydroponics [hydroponics],
  Beta National Guard Camp [national_guard_camp],
  More Locations [more_locations],
  Fuji's More Buildings [FujiStruct],
  Urban Development [Urban_Development],
  Vehicle Additions Pack [blazemod],
  Folding Parts pack [deoxymod],
  Tanks and Other Vehicles [Tanks],
  Necromancy [necromancy],
  Disable Religious Texts [no_religious_Texts],
  No Fungal Monsters [No_Fungi],
  Safe Autodoc [safeautodoc],
  Classes and Scenarios Mod [more_classes_scenarios],
  Disable NPC Needs [no_npc_food],
  Manual Bionic Installation [manualbionicinstall],
  Simplified Nutrition [novitamins],
  Stats Through Kills [stats_through_kills],
  StatsThroughSkills [StatsThroughSkills],
  SpeedyDex [speedydex]
  ]

[Leland]

Weirdly, that recipe is set to never_learn:

Cataclysm-DDA/data/json/recipes/basecamps/recipe_primitive_field.json

Lines 722 to 729 in 9f59a93

	"result": "faction_base_kitchen_2",
	"description": "We need to finish framing the walls for the cook-shack.",
	"category": "CC_BUILDING",
	"subcategory": "CSC_BUILDING_BASES",
	"skill_used": "fabrication",
	"difficulty": 4,
	"autolearn": false,
	"never_learn": true,

...which is supposed to prevent this from being learned at all, regardless of where it's been included:

Cataclysm-DDA/src/player.cpp

Lines 10453 to 10459 in 9f59a93

	void player::learn_recipe( const recipe *const rec )
	{
	if( rec->never_learn ) {
	return;
	}
	learned_recipes->include( rec );
	}

Wonder how this happened.

[Melodeiro]

Where is the DEBUG word from then? Maybe that recipe is not from json, but hardcoded somewhere?

[Melodeiro]

I guess, you need to add never_learn check here:

Cataclysm-DDA/src/iuse.cpp

Line 5955 in ec26a7e

if( r.difficulty >= 3 && one_in( r.difficulty + 1 ) ) {

I don't see any checks when recipe is added to e-ink