Check for never_learn before adding candidate recipes to sdcard #36566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
This was referenced Jan 5, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Check for never_learn before adding candidate recipes to sdcard"Purpose of change
Fixes #33349
Describe the solution
Add a check for never_learn as it loops through all recipes.
Describe alternatives you've considered
N/A
Testing
tricky to test I guess. Couldnt actually test it properly - I spawned 100 sdcards and downloaddd recipes from all of them and not seeing faction base recipe get loaded in, which would probably b e the case anyway , as its not likely to pop up other than like 1 in 500 times.
Though im fairly confident this fixes it.
Additional context
N/A