Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canned items are spawning opened again #40127

Closed
aoae23 opened this issue May 4, 2020 · 10 comments · Fixed by #41745
Closed

Canned items are spawning opened again #40127

aoae23 opened this issue May 4, 2020 · 10 comments · Fixed by #41745
Assignees
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things

Comments

@aoae23
Copy link
Contributor

aoae23 commented May 4, 2020

Describe the bug

Canned items are spawning opened rather than sealed.

Steps To Reproduce

  1. Create a new world. Spawn a character.
    2a. Teleport around until you find somewhere with canned goods. (I looked at both an evac shelter and a house.)
    2b. Alternatively, use debug spawn to spawn a canned item. The can spawns opened.
  2. Optionally, accelerate time to confirm that the items do rot.

Expected behavior

Canned goods should spawn sealed, rather than opened as if some passive aggressive survivor had been through the area prior.
This bug also prevents storing canned goods in clothes, since they must be sealed for that to be possible.

Screenshots

image
image after 20 days
image

Versions and configuration

OS: Windows 10
Version: 0.E-1713-gd15c896
Graphics: Tiles
Language: English
Mods:
image

Additional context

None

@ZhilkinSerg ZhilkinSerg added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things labels May 4, 2020
@Kanexan
Copy link
Contributor

Kanexan commented May 4, 2020

From what I've seen, this is only the case for medium tin cans for some reason. I've been able to pick up large tin cans without needing to unload them, and they're still considered sealed as well.

@TheMurderUnicorn
Copy link
Contributor

Naw, also an issue with small cans. Can't stow them, presumably because they're 'open'.
image

@Resok
Copy link
Contributor

Resok commented May 5, 2020

I found this issue also -

#40180

If I use the debug menu to spawn in a container it seems to remain sealed but any items that were sealed previously are flagged as unsealed.

I believe this is related to the pockets change -

image

@Emotions211
Copy link
Contributor

A workaround for not being able to pickup items and immediately store them automatically is to (w)eild the item, open your (i)nventory and (i)nsert it into a pocket. However this takes a few turns to accomplish. However I'm only having this issue with canned drinks like Energy Drinks and Sodas. Spilling them also gives you a frozen liquid that can only be dropped. Thawing it spills it onto the ground with no dialogue for choosing what to do with it.

@Elpyfo
Copy link

Elpyfo commented May 21, 2020

Issue #40658 contains a save file for this issue in case it helps.

@DillonSimeone
Copy link
Contributor

DillonSimeone commented May 24, 2020

Trying to cause this... Testing on build 10689.

Running around.

image

image

image

image

All seems to be well. Spotted canned stuff in houses too, no issues with those. See new comment below.

@DillonSimeone
Copy link
Contributor

Turns out that this happens with Can of x drink, not canned foods/soup.

You can reproduce this bug with the overmap editior as shown below:

Placing house_01 on the overmap in ungenerated areas then teleporting over.
image

image

Walk into a placed house with a fridge AND cans in it, then attempt to pick up a can...
image

image

Double check that I'm in the houses I placed...

image

@kevingranade
Copy link
Member

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/cant-store-cans-and-some-other-items-in-my-inventory/23996/12

@EpicMarble
Copy link

Based on limited testing, I've noticed that cans of beer will spawn opened in homes, but closed in bars and grocery stores.

2020-06-22-1000-6884

2020-06-22-1000-6885

@olanti-p
Copy link
Contributor

Another way to reproduce is to debug spawn NPCs.
For every dozen NPCs there are 1-2 popups of What to do with the chocolate drink (1)?
The dialogue spam may be a bit annoying, but that's solved with a pair of ear plugs

@ZhilkinSerg ZhilkinSerg unpinned this issue Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things
Projects
None yet